add disableGzipContent option for create from InputStream #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
nblair
force-pushed
the
blobwriteoption-disableGzipCompression
branch
from
375fdb3
to
d0ef86f
Compare
yoshi-kokoro
removed
the
kokoro:run
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
============================================
+ Coverage 63.3% 63.32% +0.01%
Complexity 528 528
============================================
Files 30 30
Lines 4720 4722 +2
Branches 450 450
============================================
+ Hits 2988 2990 +2
Misses 1571 1571
Partials 161 161
Continue to review full report at Codecov.
|
…s#36) Previously, only the methods to create blobs that take a byte[] argument offer the option to disable gzip compression; the methods that accept an InputStream argument do not. This is due to the BlobWriteOption enum missing a matching constant for BlobTargetOption.IF_DISABLE_GZIP_CONTENT. This change set adds a matching IF_DISABLE_GZIP_CONTENT constant to BlobWriteOption including the correct translation to StorageRpc.Option. The net result is that the Storage create functions that accept an InputStream now offer the option to disable gzip compression.
nblair
force-pushed
the
blobwriteoption-disableGzipCompression
branch
from
b84e5db
to
183d0c6
Compare
athakor
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
Hi there! I'm curious if you have any feedback or questions on the idea and the approach? Thanks in advance! |
frankyn
added
the
kokoro:force-run
frankyn
approved these changes
Feb 14, 2020
|
Change LGTM, pending tests to finish and will merge. Thank you for your contribution @nblair! |
frankyn
added
kokoro:force-run
yoshi-kokoro
removed
kokoro:run
|
Thanks for your time @frankyn - cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your feature request related to a problem? Please describe.
I have a use case that necessitates using the Storage/Bucket write method variants with InputStream arguments. The inputs for my use case to store in Cloud Storage are:
Describe the solution you'd like
Given that our content is already compressed, I would prefer to avoid spending the CPU time on compressing the content again en route to the Bucket.
Describe alternatives you've considered
We have used the
byte[]variants, withBlobTargetOption.disableGzipContentand the Compose request. This is suitable but leaves us with a tuning challenge:byte[]chunks) requires additional heap space be available32 * bufferSize, we will upload 31 small sized chunks and 1 large chunk that we have to use theInputStreamvariant for anyways, and pay the additional overhead of gzip compression.Additional context
I have done some exploration and it appears that the values on the BlobWriteOption (used on
InputStreamvariants) and BlobTargetOption (used onbyte[]variants) enums both are translated intoStorageRpc.Option. I have a small contribution to offer in the form of a pull request to follow.Fixes #36; ported from googleapis/google-cloud-java#7057