Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unnecessary options in resumable upload URL #679

Merged
merged 2 commits into from Jan 12, 2021

Conversation

JesseLovelace
Copy link
Contributor

Fix unnecessary options in resumable upload URL by explicitly selecting them instead of iterating though all

@JesseLovelace JesseLovelace requested review from frankyn and a team January 12, 2021 19:20
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/java-storage API. label Jan 12, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 12, 2021
Copy link
Member

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending kokoro.

@frankyn frankyn changed the title Fix unnecessary options in resumable upload URL fix: unnecessary options in resumable upload URL Jan 12, 2021
@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #679 (5c16364) into master (ebb5fb2) will increase coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #679      +/-   ##
============================================
+ Coverage     64.26%   64.33%   +0.07%     
- Complexity      621      630       +9     
============================================
  Files            32       32              
  Lines          5322     5322              
  Branches        521      520       -1     
============================================
+ Hits           3420     3424       +4     
+ Misses         1740     1733       -7     
- Partials        162      165       +3     
Impacted Files Coverage Δ Complexity Δ
...om/google/cloud/storage/spi/v1/HttpStorageRpc.java 1.55% <0.00%> (+0.01%) 2.00 <0.00> (ø)
...ava/com/google/cloud/storage/BlobWriteChannel.java 67.28% <0.00%> (-0.72%) 11.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebb5fb2...5c16364. Read the comment docs.

@JesseLovelace JesseLovelace merged commit d31a39b into master Jan 12, 2021
@JesseLovelace JesseLovelace deleted the fixencryptionkeylogging branch January 12, 2021 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants