Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: last chunk is retriable #677

Merged
merged 3 commits into from Jan 12, 2021
Merged

fix: last chunk is retriable #677

merged 3 commits into from Jan 12, 2021

Conversation

frankyn
Copy link
Member

@frankyn frankyn commented Jan 12, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Ensure the tests and linter pass
  • Appropriate docs were updated (if necessary)

Fixes #666 ☕️

@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/java-storage API. label Jan 12, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 12, 2021
@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #677 (4d58f07) into master (ebb5fb2) will decrease coverage by 0.00%.
The diff coverage is 37.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #677      +/-   ##
============================================
- Coverage     64.26%   64.25%   -0.01%     
- Complexity      621      630       +9     
============================================
  Files            32       32              
  Lines          5322     5329       +7     
  Branches        521      524       +3     
============================================
+ Hits           3420     3424       +4     
  Misses         1740     1740              
- Partials        162      165       +3     
Impacted Files Coverage Δ Complexity Δ
...om/google/cloud/storage/spi/v1/HttpStorageRpc.java 1.54% <0.00%> (ø) 2.00 <0.00> (ø)
...ava/com/google/cloud/storage/BlobWriteChannel.java 67.28% <42.85%> (-0.72%) 11.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebb5fb2...4d58f07. Read the comment docs.

@frankyn frankyn marked this pull request as ready for review January 12, 2021 18:58
@frankyn frankyn requested a review from a team January 12, 2021 18:58
@BenWhitehead BenWhitehead added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 12, 2021
@frankyn frankyn added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 12, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 12, 2021
@frankyn frankyn added the automerge Merge the pull request once unit tests and other checks pass. label Jan 12, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 44f49e0 into master Jan 12, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the fix-issue branch January 12, 2021 20:52
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StorageException: Resumable upload is already complete.
3 participants