Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent NPE in RemoteStorageHelper.cleanBuckets #492

Merged
merged 1 commit into from Sep 1, 2020

Conversation

Gerschtli
Copy link
Contributor

The method getEventBasedHold and getTemporaryHold return Boolean objects which are either true, false or null. In case of a null value, this produced a NPE.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 31, 2020
@codecov
Copy link

codecov bot commented Aug 31, 2020

Codecov Report

Merging #492 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #492      +/-   ##
============================================
- Coverage     64.60%   64.59%   -0.02%     
+ Complexity      626      617       -9     
============================================
  Files            32       32              
  Lines          5235     5236       +1     
  Branches        506      508       +2     
============================================
  Hits           3382     3382              
- Misses         1694     1695       +1     
  Partials        159      159              
Impacted Files Coverage Δ Complexity Δ
...gle/cloud/storage/testing/RemoteStorageHelper.java 64.00% <0.00%> (-0.52%) 9.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 913b756...ef31035. Read the comment docs.

The method getEventBasedHold and getTemporaryHold return Boolean objects
which are either true, false or null. In case of a null value, this
produced a NPE.
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/java-storage API. label Sep 1, 2020
@athakor athakor added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Sep 1, 2020
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 1, 2020
@frankyn frankyn merged commit db358c8 into googleapis:master Sep 1, 2020
@Gerschtli Gerschtli deleted the fix-npe branch September 1, 2020 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants