feat: add support of null to remove the CORS configuration from bucket #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #438 +/- ##
============================================
+ Coverage 63.15% 63.17% +0.01%
- Complexity 610 619 +9
============================================
Files 32 32
Lines 5133 5133
Branches 490 489 -1
============================================
+ Hits 3242 3243 +1
Misses 1726 1726
+ Partials 165 164 -1
Continue to review full report at Codecov.
|
frankyn
requested changes
Jul 20, 2020
| @@ -1509,7 +1509,7 @@ public StorageClass getStorageClass() { | |||
| * (CORS)</a> | |||
| */ | |||
| public List<Cors> getCors() { | |||
| return cors; | |||
| return cors != null ? cors : ImmutableList.<Cors>of(); | |||
There was a problem hiding this comment.
Please leave this field as is and revert change. There are potentially 4 cases which are considered here and we don't want to mess them up.
- Cors are set and field selector is selected then returns not-null.
- Cors are set but field selector isn't selected then returns null.
- Cors are not set and field selector is selected then returns null.
- Cors are not set and field selector isn't selected then returns null.
|
@frankyn PTAL |
frankyn
approved these changes
Jul 22, 2020
pmakani
pushed a commit
to pmakani/java-storage
that referenced
this pull request
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #437