feat: add support of startOffset and endOffset #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #430 +/- ##
============================================
- Coverage 63.27% 63.15% -0.12%
+ Complexity 618 610 -8
============================================
Files 32 32
Lines 5113 5133 +20
Branches 486 490 +4
============================================
+ Hits 3235 3242 +7
- Misses 1713 1726 +13
Partials 165 165
Continue to review full report at Codecov.
|
frankyn
requested changes
Jul 14, 2020
| storage.list( | ||
| bucketName, | ||
| Storage.BlobListOption.startOffset("test-list-blobs-start-offset-blob"), | ||
| Storage.BlobListOption.endOffset("test-list-blobs-end-offset-blob3")); |
There was a problem hiding this comment.
Recommend starting from not the first object in the new objects.
There was a problem hiding this comment.
Replace this test with new one.
| Storage.BlobListOption.startOffset("test-list-blobs-start-offset-blob"), | ||
| Storage.BlobListOption.endOffset("test-list-blobs-end-offset-blob3")); | ||
| // Listing blobs is eventually consistent, we loop until the list is of the expected size. | ||
| while (Iterators.size(page.iterateAll().iterator()) != 3) { |
There was a problem hiding this comment.
I can't tell if this is working because it's using all the objects created during the test.
There was a problem hiding this comment.
@frankyn yes you are right, i have wrote new test instead of that. Now you can easily verify it.
athakor
added
kokoro:force-run
yoshi-kokoro
removed
kokoro:run
|
@frankyn PTAL |
frankyn
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #424