fix: throw io exception instead of storage exception #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #229 +/- ##
============================================
- Coverage 63.67% 63.50% -0.18%
+ Complexity 548 540 -8
============================================
Files 31 30 -1
Lines 4782 4762 -20
Branches 428 427 -1
============================================
- Hits 3045 3024 -21
- Misses 1577 1578 +1
Partials 160 160
Continue to review full report at Codecov.
|
elharo
approved these changes
Apr 7, 2020
|
@elharo could I get your review on this PR. I want another perspective. |
frankyn
requested changes
Apr 7, 2020
There was a problem hiding this comment.
Still reviewing. Thanks for putiing this together @dmitry-fa
| @@ -133,12 +133,12 @@ public int read(ByteBuffer byteBuffer) throws IOException { | |||
| if (result.y().length > 0 && lastEtag != null && !Objects.equals(result.x(), lastEtag)) { | |||
| StringBuilder messageBuilder = new StringBuilder(); | |||
| messageBuilder.append("Blob ").append(blob).append(" was updated while reading"); | |||
| throw new StorageException(0, messageBuilder.toString()); | |||
There was a problem hiding this comment.
I'm wondering if this will no longer be retried. Well it shouldn't be so maybe that's not an issue.
google-cloud-storage/src/main/java/com/google/cloud/storage/BlobReadChannel.java
Show resolved
Hide resolved
elharo
approved these changes
Apr 7, 2020
frankyn
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #219