Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make the getStorageClass() method public #22

Merged
merged 1 commit into from Jan 16, 2020
Merged

fix: make the getStorageClass() method public #22

merged 1 commit into from Jan 16, 2020

Conversation

dmitry-fa
Copy link
Contributor

Fixes #21

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 27, 2019
@pmakani pmakani added the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 27, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 27, 2019
@codecov
Copy link

codecov bot commented Dec 27, 2019 •
edited

Codecov Report

Merging #22 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #22   +/-   ##
=========================================
  Coverage     63.29%   63.29%           
  Complexity      528      528           
=========================================
  Files            30       30           
  Lines          4719     4719           
  Branches        450      450           
=========================================
  Hits           2987     2987           
  Misses         1571     1571           
  Partials        161      161
Impacted Files Coverage Δ Complexity Δ
...main/java/com/google/cloud/storage/BucketInfo.java 81.04% <ø> (ø) 84 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fda3eda...acb08d4. Read the comment docs.

@chingor13
Copy link
Collaborator

This one is not up to me. Adding Frank

@chingor13 chingor13 requested review from frankyn and removed request for chingor13 December 27, 2019 17:36
@dmitry-fa
Copy link
Contributor Author

@frankyn gentle ping

frankyn
frankyn approved these changes Jan 16, 2020
View reviewed changes
Copy link
Member

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Checked in with @JesseLovelace to double check.

@frankyn frankyn merged commit 7fb1f6c into googleapis:master Jan 16, 2020
@dmitry-fa dmitry-fa deleted the FA.7046 branch June 26, 2020 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankyn frankyn frankyn approved these changes

@JesseLovelace JesseLovelace Awaiting requested review from JesseLovelace

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cloud Storage: getStorageClass in SetStorageClassLifecycleAction is not visible
6 participants
@dmitry-fa @chingor13 @frankyn @googlebot @kokoro-team @pmakani