fix: Blob.downloadTo() methods do not wrap RetryHelper$RetryHelperException

[dmitry-fa]

Fixes #100

[codecov]

Codecov Report

Merging #218 into master will increase coverage by 0.17%.
The diff coverage is 91.66%.

@@             Coverage Diff              @@
##             master     #218      +/-   ##
============================================
+ Coverage     63.50%   63.67%   +0.17%     
- Complexity      540      548       +8     
============================================
  Files            30       31       +1     
  Lines          4759     4785      +26     
  Branches        427      428       +1     
============================================
+ Hits           3022     3047      +25     
- Misses         1577     1578       +1     
  Partials        160      160              

Impacted Files	Coverage Δ	Complexity Δ
...e/src/main/java/com/google/cloud/storage/Blob.java	81.97% <91.66%> (-0.28%)	29.00 <0.00> (ø)
...va/com/google/cloud/storage/StorageOperations.java	100.00% <0.00%> (ø)	8.00% <0.00%> (?%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 010c112...aee34fb. Read the comment docs.

[elharo]

Per Google practices, new tests should use Mockito, not EasyMock. Yes, even if this means some tests use Mockito and others use EasyMock.

[dmitry-fa]

Is this rule applied to the tests within a single file or withing a package?
Is it possible to make an exception?

[frankyn]

LGTM

[frankyn]

I think we will need to make an exception for now but may be good to file an issue to track it as future work.

…

On Wed, Apr 1, 2020, 11:57 PM Dmitry ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In google-cloud-storage/src/test/java/com/google/cloud/storage/BlobTest.java <#218 (comment)> : > @@ -662,4 +661,25 @@ public Long answer() throws Throwable { byte actual[] = Files.readAllBytes(file.toPath()); assertArrayEquals(expected, actual); } + + @test Is this rule applied to the tests within a single file or withing a package? Is it possible to make an exception? — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#218 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAORXQB5KYTBLUVFXI4DNWDRKQZMBANCNFSM4LXMU2UQ> .