Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify documentation on date formats. #196

Merged
merged 1 commit into from Mar 19, 2020
Merged

docs: clarify documentation on date formats. #196

merged 1 commit into from Mar 19, 2020

Conversation

johnalowry
Copy link
Contributor

I added the following code:

System.out.printf("Blob updatetime: %s", blob.getUpdateTime());

The output was

Blob updatetime: 1582157090238

I verified that this was ms after epoch:

$ date -d @1582157090
Wed 19 Feb 2020 04:04:50 PM PST

I also traced the code to this function:

https://github.com/googleapis/google-http-java-client/blob/master/google-http-client/src/main/java/com/google/api/client/util/DateTime.java#L53

I assumed that create and delete times used the same format.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 18, 2020
@frankyn frankyn self-requested a review March 18, 2020 22:07
@frankyn frankyn added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 18, 2020
@frankyn frankyn changed the title docs: Clarify documentation on date formats. docs: clarify documentation on date formats. Mar 18, 2020
@frankyn
Copy link
Member

frankyn commented Mar 18, 2020

Do:
git commit --amend
Lowercase the word Clarify

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 18, 2020
@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #196 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #196      +/-   ##
===========================================
+ Coverage     63.43%   63.5%   +0.06%     
  Complexity      540     540              
===========================================
  Files            30      30              
  Lines          4759    4759              
  Branches        427     427              
===========================================
+ Hits           3019    3022       +3     
+ Misses         1580    1577       -3     
  Partials        160     160
Impacted Files Coverage Δ Complexity Δ
...c/main/java/com/google/cloud/storage/BlobInfo.java 88.95% <ø> (ø) 88 <0> (ø) ⬇️
...gle/cloud/storage/testing/RemoteStorageHelper.java 63.93% <0%> (+2.45%) 9% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c7a498...74129cd. Read the comment docs.

@frankyn
Copy link
Member

frankyn commented Mar 18, 2020

Forgot to add, then do:
git push -f to force the commit amend.

@frankyn
Copy link
Member

frankyn commented Mar 18, 2020

To fix lint issues run the following maven command:
mvn com.coveo:fmt-maven-plugin:format

@frankyn
Copy link
Member

frankyn commented Mar 18, 2020

I'll merge once Code Format is fixed @johnalowry.

@johnalowry
Copy link
Contributor Author

thanks - it should all be fixed now

@frankyn frankyn added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 18, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 18, 2020
@frankyn
Copy link
Member

frankyn commented Mar 18, 2020

Thanks @johnalowry, format is still failing.

@johnalowry
Copy link
Contributor Author

i ran the mvn command after the git push... i've run git push again and it looks like the checks are now running. hopefully that fixes.

@frankyn frankyn added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 18, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 18, 2020
System.out.printf("Blob updatetime: %s", blob.getUpdateTime());

The output was

Blob updatetime: 1582157090238

I verified that this was ms after epoch:

$ date -d @1582157090
Wed 19 Feb 2020 04:04:50 PM PST

I also traced the code to this function:

https://github.com/googleapis/google-http-java-client/blob/master/google-http-client/src/main/java/com/google/api/client/util/DateTime.java#L53

I assumed that create and delete times used the same format.
@frankyn frankyn added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 18, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 18, 2020
@frankyn
Copy link
Member

frankyn commented Mar 18, 2020

Fixed format, to get it over the hump. Thanks for your patience @johnalowry

@frankyn frankyn merged commit 9b4af58 into googleapis:master Mar 19, 2020
@frankyn frankyn removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 19, 2020
yoshi-automation added a commit that referenced this pull request Mar 30, 2020
9b4af58
commit 9b4af58
Author: johnalowry <jlowry@google.com>
Date:   Wed Mar 18 17:01:52 2020 -0700

    docs: clarify documentation on date formats (#196)

    System.out.printf("Blob updatetime: %s", blob.getUpdateTime());

    The output was

    Blob updatetime: 1582157090238

    I verified that this was ms after epoch:

    $ date -d @1582157090
    Wed 19 Feb 2020 04:04:50 PM PST

    I also traced the code to this function:

    https://github.com/googleapis/google-http-java-client/blob/master/google-http-client/src/main/java/com/google/api/client/util/DateTime.java#L53

    I assumed that create and delete times used the same format.
chingor13 pushed a commit that referenced this pull request Apr 1, 2020
* Change triggered by none of the following:
This git repo (https://github.com/googleapis/java-storage.git)

* docs: clarify documentation on date formats (#196)

9b4af58
commit 9b4af58
Author: johnalowry <jlowry@google.com>
Date:   Wed Mar 18 17:01:52 2020 -0700

    docs: clarify documentation on date formats (#196)

    System.out.printf("Blob updatetime: %s", blob.getUpdateTime());

    The output was

    Blob updatetime: 1582157090238

    I verified that this was ms after epoch:

    $ date -d @1582157090
    Wed 19 Feb 2020 04:04:50 PM PST

    I also traced the code to this function:

    https://github.com/googleapis/google-http-java-client/blob/master/google-http-client/src/main/java/com/google/api/client/util/DateTime.java#L53

    I assumed that create and delete times used the same format.

* chore: use java helper for templates (#195)

b0ffd0b
commit b0ffd0b
Author: Jeff Ching <chingor@google.com>
Date:   Wed Mar 18 17:04:08 2020 -0700

    chore: use java helper for templates (#195)

    We are cleaning up usage of common templates in synthtool. This allows us the cleanup usage in a centralized place rather than in 60+ repos

* deps: update dependency org.threeten:threetenbp to v1.4.2 (#200)

84faad1
commit 84faad1
Author: WhiteSource Renovate <bot@renovateapp.com>
Date:   Sat Mar 21 03:39:53 2020 +0100

    deps: update dependency org.threeten:threetenbp to v1.4.2 (#200)

* deps: update dependency com.google.api:api-common to v1.9.0 (#209)

789ceaa
commit 789ceaa
Author: WhiteSource Renovate <bot@renovateapp.com>
Date:   Thu Mar 26 00:22:02 2020 +0100

    deps: update dependency com.google.api:api-common to v1.9.0 (#209)

    This PR contains the following updates:

    | Package | Update | Change |
    |---|---|---|
    | [com.google.api:api-common](https://togithub.com/googleapis/api-common-java) | minor | `1.8.1` -> `1.9.0` |

    ---

    ### Release Notes

    <details>
    <summary>googleapis/api-common-java</summary>

    ### [`v1.9.0`](https://togithub.com/googleapis/api-common-java/releases/v1.9.0)

    [Compare Source](https://togithub.com/googleapis/api-common-java/compare/v1.8.1...v1.9.0)

    03-25-2020 14:09 PST

    #### New Features

    -   Add `@BetaApi` `ApiFutres.catchingAsync()` ([#&#8203;117](https://togithub.com/googleapis/api-common-java/pull/117))

    ##### Dependencies

    -   Update guava to v28.2-android ([#&#8203;110](https://togithub.com/googleapis/api-common-java/pull/110))
    -   Update error_prone_annotations to v2.2.3 ([#&#8203;111](https://togithub.com/googleapis/api-common-java/pull/111))

    </details>

    ---

    ### Renovate configuration

    📅 **Schedule**: At any time (no schedule defined).

    🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

    ♻️ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

    🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

    ---

     - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

    ---

    This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-storage).

* samples: fix install-without-bom version (#211)

08750db
commit 08750db
Author: Jeff Ching <chingor@google.com>
Date:   Fri Mar 27 15:09:06 2020 -0700

    samples: fix install-without-bom version (#211)

    * samples: fix install-without-bom version

    * samples: fix snapshot version

    * samples: fix libraries-bom version

* fix: storage-client-lib-docs to right location (#213)

133d137
commit 133d137
Author: Frank Natividad <frankyn@users.noreply.github.com>
Date:   Fri Mar 27 15:44:02 2020 -0700

    fix: storage-client-lib-docs to right location (#213)

* deps: update conformance test dep (#210)

010c112
commit 010c112
Author: JesseLovelace <43148100+JesseLovelace@users.noreply.github.com>
Date:   Fri Mar 27 15:59:00 2020 -0700

    deps: update conformance test dep (#210)

    * Update conformance test dep

    * Update conformance test dep

* chore: fix synth.py error and enable multiple autosynth commits (#215)

2faeb54
commit 2faeb54
Author: Jeff Ching <chingor@google.com>
Date:   Mon Mar 30 09:56:42 2020 -0700

    chore: fix synth.py error and enable multiple autosynth commits (#215)

* deps: update dependency com.google.cloud.samples:shared-configuration to v1.0.14 (#207)

be74072
commit be74072
Author: WhiteSource Renovate <bot@renovateapp.com>
Date:   Mon Mar 30 22:25:27 2020 +0200

    deps: update dependency com.google.cloud.samples:shared-configuration to v1.0.14 (#207)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants