Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add delimiter BlobListOption #102

Merged
merged 4 commits into from Feb 14, 2020
Merged

feat: add delimiter BlobListOption #102

merged 4 commits into from Feb 14, 2020

Conversation

athakor
Copy link
Contributor

@athakor athakor commented Jan 30, 2020

Fixes #99

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 30, 2020
@codecov
Copy link

codecov bot commented Jan 30, 2020 •
edited

Codecov Report

Merging #102 into master will increase coverage by 0.32%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #102      +/-   ##
============================================
+ Coverage     63.30%   63.62%   +0.32%     
- Complexity      528      539      +11     
============================================
  Files            30       30              
  Lines          4720     4729       +9     
  Branches        450      426      -24     
============================================
+ Hits           2988     3009      +21     
+ Misses         1571     1562       -9     
+ Partials        161      158       -3
Impacted Files Coverage Δ Complexity Δ
...in/java/com/google/cloud/storage/StorageBatch.java 88.00% <0.00%> (-4.00%) 13.00% <0.00%> (ø%)
...gle/cloud/storage/testing/RemoteStorageHelper.java 64.46% <0.00%> (-0.58%) 9.00% <0.00%> (ø%)
...main/java/com/google/cloud/storage/BucketInfo.java 80.85% <0.00%> (-0.20%) 84.00% <0.00%> (ø%)
...e/src/main/java/com/google/cloud/storage/Blob.java 82.24% <0.00%> (-0.11%) 29.00% <0.00%> (-1.00%)
...om/google/cloud/storage/spi/v1/HttpStorageRpc.java 1.64% <0.00%> (+<0.01%) 1.00% <0.00%> (ø%) ⬆️
...rc/main/java/com/google/cloud/storage/Storage.java 80.68% <0.00%> (+0.63%) 0.00% <0.00%> (ø%) ⬆️
...n/java/com/google/cloud/storage/SignatureInfo.java 81.50% <0.00%> (+0.81%) 19.00% <0.00%> (+2.00%) ⬇️
...ain/java/com/google/cloud/storage/StorageImpl.java 78.67% <0.00%> (+1.85%) 120.00% <0.00%> (+10.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 195096c...62a567b. Read the comment docs.

@athakor athakor added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 4, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 4, 2020
@athakor athakor requested a review from frankyn February 7, 2020 08:45
frankyn
frankyn reviewed Feb 7, 2020
View reviewed changes
google-cloud-storage/src/main/java/com/google/cloud/storage/Storage.java Outdated
@@ -988,6 +988,11 @@ public static BlobListOption currentDirectory() {
return new BlobListOption(StorageRpc.Option.DELIMITER, true);
}

/** Returns an option to set a delimiter '/'. */
public static BlobListOption delimiter() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delimiter can be user defined, generally '/' is the one used most often, but I'd like to keep this open to other delimiters.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@athakor athakor added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 10, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 10, 2020
@athakor
Copy link
Contributor Author

athakor commented Feb 10, 2020

@frankyn PTAL

frankyn
frankyn approved these changes Feb 14, 2020
View reviewed changes
Copy link
Member

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@frankyn frankyn merged commit b30a675 into googleapis:master Feb 14, 2020
@yoshi-automation yoshi-automation mentioned this pull request Feb 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankyn frankyn frankyn approved these changes

@JesseLovelace JesseLovelace Awaiting requested review from JesseLovelace

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add delimiter BlobListOption
4 participants
@athakor @frankyn @googlebot @yoshi-kokoro