Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Revert "feat: expose all the methods of notification (#141)" (#393)
This reverts commit 8dfc0cb.
  • Loading branch information
frankyn committed Jun 25, 2020
1 parent 8dfc0cb commit 3e02b9c
Show file tree
Hide file tree
Showing 14 changed files with 1 addition and 743 deletions.
25 changes: 0 additions & 25 deletions google-cloud-storage/clirr-ignored-differences.xml
Expand Up @@ -26,29 +26,4 @@
<method>com.google.cloud.storage.BucketInfo$Builder deleteLifecycleRules()</method>
<differenceType>7013</differenceType>
</difference>
<difference>
<className>com/google/cloud/storage/Storage</className>
<method>com.google.api.services.storage.model.Notification createNotification(java.lang.String, com.google.cloud.storage.NotificationInfo)</method>
<differenceType>7012</differenceType>
</difference>
<difference>
<className>com/google/cloud/storage/Storage</className>
<method>com.google.api.services.storage.model.Notification getNotification(java.lang.String, java.lang.String)</method>
<differenceType>7012</differenceType>
</difference>
<difference>
<className>com/google/cloud/storage/Storage</className>
<method>java.util.List listNotifications(java.lang.String)</method>
<differenceType>7012</differenceType>
</difference>
<difference>
<className>com/google/cloud/storage/Storage</className>
<method>boolean deleteNotification(java.lang.String, java.lang.String)</method>
<differenceType>7012</differenceType>
</difference>
<difference>
<className>com/google/cloud/storage/spi/v1/StorageRpc</className>
<method>com.google.api.services.storage.model.Notification getNotification(java.lang.String, java.lang.String)</method>
<differenceType>7012</differenceType>
</difference>
</differences>
5 changes: 0 additions & 5 deletions google-cloud-storage/pom.xml
Expand Up @@ -155,11 +155,6 @@
<artifactId>truth</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-pubsub</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.easymock</groupId>
<artifactId>easymock</artifactId>
Expand Down

This file was deleted.

Expand Up @@ -21,7 +21,6 @@

import com.google.api.core.InternalExtensionOnly;
import com.google.api.gax.paging.Page;
import com.google.api.services.storage.model.Notification;
import com.google.auth.ServiceAccountSigner;
import com.google.auth.ServiceAccountSigner.SigningException;
import com.google.cloud.FieldSelector;
Expand Down Expand Up @@ -3434,36 +3433,4 @@ List<Boolean> testIamPermissions(
* @throws StorageException upon failure
*/
ServiceAccount getServiceAccount(String projectId);

/**
* Creates a notification with the specified entity on the specified bucket.
*
* @return the notification that was created.
* @throws StorageException upon failure
*/
Notification createNotification(String bucket, NotificationInfo notification);

/**
* Get the notification with the specified name on the specified object.
*
* @return the notification object that exist on the bucket.
* @throws StorageException upon failure
*/
Notification getNotification(String bucket, String notification);

/**
* List the notifications for the provided bucket.
*
* @return a list of {@link Notification} objects that exist on the bucket.
* @throws StorageException upon failure
*/
List<Notification> listNotifications(String bucket);

/**
* Deletes the notification with the specified name on the specified object.
*
* @return {@code true} if the notification was deleted, {@code false} if it was not found
* @throws StorageException upon failure
*/
boolean deleteNotification(String bucket, String notification);
}

0 comments on commit 3e02b9c

Please sign in to comment.