Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make the StorageOption returned by LocalStorageHelper.getOptions() serializable #606

Merged
merged 3 commits into from Jul 1, 2021

Conversation

jianglai
Copy link
Contributor

@jianglai jianglai commented Jul 1, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #605 ☕️

@jianglai jianglai requested a review from a team as a code owner July 1, 2021 00:56
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/java-storage-nio API. label Jul 1, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 1, 2021
@jianglai jianglai changed the title Make the StorageOption returned by LocalStorageHelper.getOptions() serializable fix: Make the StorageOption returned by LocalStorageHelper.getOptions() serializable Jul 1, 2021
(tweaked code to work with customOptions)
@BenWhitehead
Copy link
Collaborator

thanks for the contribution @jianglai! I've pushed an additional commit which also tests the customOptions path (and slightly tweaked the factory to support that).

@BenWhitehead BenWhitehead added the automerge Merge the pull request once unit tests and other checks pass. label Jul 1, 2021
@BenWhitehead BenWhitehead self-assigned this Jul 1, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 12e872b into googleapis:master Jul 1, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 1, 2021
@jianglai jianglai deleted the serializable branch July 1, 2021 19:00
@jianglai
Copy link
Contributor Author

jianglai commented Jul 1, 2021

Thank you! Any chance you can cut a release soon so that I can actually use it?

@BenWhitehead
Copy link
Collaborator

We did a release last yesterday which is currently flowing out through the larger gcp library suite, so once that's complete we can easily cut a new release here.

@jianglai
Copy link
Contributor Author

Hi Ben, do you have an ETA on when the next release is happening?

@BenWhitehead
Copy link
Collaborator

Apologies on the delay, I've just triggered the release and it should be available on maven central soon.

@BenWhitehead
Copy link
Collaborator

Release version is v0.123.4

@jianglai
Copy link
Contributor Author

jianglai commented Aug 3, 2021

Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage-nio API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LocalStorageHelper.getOption() returns a non-serializable StorageOptions
2 participants