Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cleanup use of non-preferred terms #411

Merged
merged 1 commit into from Feb 9, 2021
Merged

fix: cleanup use of non-preferred terms #411

merged 1 commit into from Feb 9, 2021

Conversation

BenWhitehead
Copy link
Collaborator

  • replace poem with lorem ipsum in CloudStorageFileSystemProviderTest

@BenWhitehead
fix: cleanup use of non-preferred terms
d8d5930 
* replace poem with lorem ipsum in CloudStorageFileSystemProviderTest
@BenWhitehead BenWhitehead requested a review from a team as a code owner February 9, 2021 21:02
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 9, 2021
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/java-storage-nio API. label Feb 9, 2021
@codecov
Copy link

codecov bot commented Feb 9, 2021 •
edited

Codecov Report

Merging #411 (248d494) into master (0d5ed3c) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #411   +/-   ##
=========================================
  Coverage     72.29%   72.29%           
  Complexity      500      500           
=========================================
  Files            29       29           
  Lines          1664     1664           
  Branches        277      277           
=========================================
  Hits           1203     1203           
  Misses          336      336           
  Partials        125      125
Impacted Files Coverage Δ Complexity Δ
...torage/contrib/nio/testing/LocalStorageHelper.java 57.14% <50.00%> (ø) 2.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d5ed3c...d8d5930. Read the comment docs.

@BenWhitehead BenWhitehead added the automerge Merge the pull request once unit tests and other checks pass. label Feb 9, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 3a3d465 into master Feb 9, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the ix-fixit branch February 9, 2021 21:26
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankyn frankyn frankyn approved these changes

@JesseLovelace JesseLovelace Awaiting requested review from JesseLovelace

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/java-storage-nio API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BenWhitehead @frankyn