Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linkage Error found while exposing getNotification in storage. #38

Closed
athakor opened this issue Feb 27, 2020 · 1 comment
Closed

Linkage Error found while exposing getNotification in storage. #38

athakor opened this issue Feb 27, 2020 · 1 comment
Assignees
Labels
api: storage Issues related to the googleapis/java-storage-nio API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@athakor
Copy link
Contributor

athakor commented Feb 27, 2020

Build failed of storage -138 due to linkage error :

SEVERE: Newly introduced problem:
(google-cloud-nio-0.120.0-alpha.jar) com.google.cloud.storage.contrib.nio.testing.FakeStorageRpc's method getNotification(String arg1, String arg2) is not implemented in the class
  referenced from com.google.cloud.storage.spi.v1.StorageRpc (google-cloud-storage-1.104.0.jar)

Solution:

public boolean deleteNotification(String bucket, String notification) {
throw new UnsupportedOperationException();
}
@Override
public List<Notification> listNotifications(String bucket) {
throw new UnsupportedOperationException();
}
@Override
public Notification createNotification(String bucket, Notification notification) {
throw new UnsupportedOperationException();
}

We have to override getNotification method in FakeStorageRpc.java once storage - 138 gets merged.

  @Override
  public Notification getNotification(String bucket, String notification){
    throw new UnsupportedOperationException();
  }
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/java-storage-nio API. label Feb 27, 2020
@athakor athakor self-assigned this Feb 27, 2020
@athakor athakor added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Feb 27, 2020
@athakor athakor changed the title Linkage Error found while exposing getNotification in storage. Linkage Error found,while exposing getNotification in storage. Feb 27, 2020
@athakor athakor changed the title Linkage Error found,while exposing getNotification in storage. Linkage Error found while exposing getNotification in storage. Feb 27, 2020
@athakor athakor added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Feb 27, 2020
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Mar 3, 2020
@frankyn frankyn added type: cleanup An internal cleanup or hygiene concern. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed 🚨 This issue needs some love. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Mar 6, 2020
@JustinBeckwith JustinBeckwith removed the type: cleanup An internal cleanup or hygiene concern. label May 14, 2020
@frankyn
Copy link
Member

frankyn commented Jun 17, 2020

Addressed in #135

@frankyn frankyn closed this as completed Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage-nio API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

4 participants