Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra conditional from FakeStorageRpc#list #210

Closed
athakor opened this issue Sep 9, 2020 · 0 comments · Fixed by #211
Closed

Remove extra conditional from FakeStorageRpc#list #210

athakor opened this issue Sep 9, 2020 · 0 comments · Fixed by #211
Assignees
Labels
api: storage Issues related to the googleapis/java-storage-nio API. type: cleanup An internal cleanup or hygiene concern.

Comments

@athakor
Copy link
Contributor

athakor commented Sep 9, 2020

Remaining clean up from PR #208
From: @frankyn
File: https://github.com/googleapis/java-storage-nio/blob/master/google-cloud-nio/src/main/java/com/google/cloud/storage/contrib/nio/testing/FakeStorageRpc.java

Saw this after, but it can help to modify the first conditional, to short circuit sooner in the sequence of code.

if (!so.getBucket().equals(bucket) || !so.getName().startsWith(prefix)) {
        continue;
}
@athakor athakor added type: cleanup An internal cleanup or hygiene concern. api: storage Issues related to the googleapis/java-storage-nio API. labels Sep 9, 2020
@athakor athakor self-assigned this Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage-nio API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant