New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move autovalue to annotation processor path #179
Conversation
2020-07-27T15:15:25.6293721Z [ERROR] com.google.cloud.storage.contrib.nio.CloudStorageFileAttributesTest.testAcl Time elapsed: 0.451 s <<< ERROR! |
Just maybe relevant: [WARNING] ***************************************************************** |
tests are running in parallel and are not using random paths:
|
Warning: This pull request is touching the following templated files:
|
This issue might be related to recent failures. Not quite sure what's going on though as I'm not able to repro this issue locally. |
d4cd678
to
8caa011
Compare
Codecov Report
@@ Coverage Diff @@
## master #179 +/- ##
============================================
+ Coverage 72.21% 72.29% +0.07%
Complexity 500 500
============================================
Files 29 29
Lines 1663 1664 +1
Branches 268 277 +9
============================================
+ Hits 1201 1203 +2
Misses 336 336
+ Partials 126 125 -1
Continue to review full report at Codecov.
|
Woot, looks like things are passing now. Pending review from @BenWhitehead when he's back in the office tomorrow. |
google-cloud-nio/pom.xml
Outdated
<path> | ||
<groupId>com.google.auto.value</groupId> | ||
<artifactId>auto-value</artifactId> | ||
<version>1.7.3</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.7.4 is out now
|
Will continue debugging. This looks related to the open failures that exist right now. |
@elharo I found that If it looks good to you, can we merge this in? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shared config has had auto-value support for some time.
We should be able to remove auto-value and auto-service and use the config from shared config.
See https://github.com/googleapis/java-firestore/pull/221/files for an example of it being used in Firestore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BenWhitehead PTAL. The commit history is becoming convoluted, but I think this is now what you asked for,
MockitoErrors in Java 7. CloudStorageLateInitializationTest.before:41 » UnsupportedClassVersion org/moc... |
Stuck on:
Thanks @elharo! |
Kokoro integrations failed again. I think it might be a flake and not sure how to reinforce without doing a retry of the tests. |
Chatting with @BenWhitehead, the kokoro build change to retry tests will be removed by autosynth... |
We will merge this PR once jobs pass and will follow-up with another solution provided by @BenWhitehead for flaky integration tests to separate tasks. |
@suraj-qlogic @suztomo
fixes #178