Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Start/End Offset in FakeStorageRpc #1274

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shubhwip
Copy link

@shubhwip shubhwip commented Oct 7, 2023

Add support for End Offset in FakeStorageRpc

Closes #1273

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1273 ☕️

If you write sample code, please follow the samples format.

Add support for End Offset in FakeStorageRpc

Closes googleapis#1273
@shubhwip shubhwip requested a review from a team as a code owner October 7, 2023 09:18
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/java-storage-nio API. labels Oct 7, 2023
@shubhwip shubhwip changed the title Add support for Start Offset in FakeStorageRpc Add support for Start/End Offset in FakeStorageRpc Oct 7, 2023
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage-nio API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for START_OFF_SET and END_OFF_SET
1 participant