Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update FakeStorageRpc to extend StorageRpcTestBase #124

Closed
dmitry-fa opened this issue Jun 8, 2020 · 0 comments · Fixed by #135
Closed

test: update FakeStorageRpc to extend StorageRpcTestBase #124

dmitry-fa opened this issue Jun 8, 2020 · 0 comments · Fixed by #135
Assignees
@dmitry-fa
Labels
api: storage Issues related to the googleapis/java-storage-nio API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. release-please:force-run To run release-please type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@dmitry-fa
Copy link
Contributor

Now FakeStorageRpc implements the StorageRpc interface from the Storage module.
This makes it impossible to extend the StorageRpc because it breaks cross-module dependencies.

Updating FakeStorageRpc to extend newly introduce StorageRpcTestBase as suggested in
googleapis/java-storage#242 will help.
@dmitry-fa dmitry-fa self-assigned this Jun 8, 2020
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/java-storage-nio API. label Jun 8, 2020
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Jun 9, 2020
@dmitry-fa dmitry-fa mentioned this issue Jun 10, 2020
Merged
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jun 13, 2020
@dmitry-fa dmitry-fa mentioned this issue Jun 15, 2020
Merged
@frankyn frankyn added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Jun 16, 2020
@frankyn frankyn added the release-please:force-run To run release-please label Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitry-fa dmitry-fa

Labels
api: storage Issues related to the googleapis/java-storage-nio API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. release-please:force-run To run release-please type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: update FakeStorageRpc to extend StorageRpcTestBase dmitry-fa/java-storage-nio
3 participants
@frankyn @yoshi-automation @dmitry-fa