Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add autoConfigEmulator connection option #931

Merged
merged 4 commits into from Mar 17, 2021

Conversation

olavloite
Copy link
Collaborator

Adds autoConfigEmulator connection option. When this option is set to true for a connection:

  1. The connection will by default try to connect to localhost:9010 (unless a specific host/port is set in the connection URL).
  2. Plain text communication will be enabled.
  3. Authentication will be disabled.
  4. The instance and database in the connection string will automatically be created on the emulator if any of them do not yet exist. Any existing instance and/or database will remain untouched.

Towards googleapis/java-spanner-jdbc#380

@olavloite olavloite requested a review from a team as a code owner March 2, 2021 10:46
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 2, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Mar 2, 2021
@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #931 (6d6676f) into master (213dddc) will increase coverage by 0.01%.
The diff coverage is 94.23%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #931      +/-   ##
============================================
+ Coverage     85.21%   85.22%   +0.01%     
- Complexity     2650     2658       +8     
============================================
  Files           145      146       +1     
  Lines         14358    14404      +46     
  Branches       1391     1395       +4     
============================================
+ Hits          12235    12276      +41     
- Misses         1540     1545       +5     
  Partials        583      583              
Impacted Files Coverage Δ Complexity Δ
...oogle/cloud/spanner/connection/ConnectionImpl.java 84.04% <0.00%> (-0.33%) 180.00 <0.00> (ø)
.../google/cloud/spanner/connection/EmulatorUtil.java 97.22% <97.22%> (ø) 3.00 <3.00> (?)
...le/cloud/spanner/connection/ConnectionOptions.java 90.53% <100.00%> (+0.32%) 89.00 <7.00> (+7.00)
...ain/java/com/google/cloud/spanner/SessionPool.java 89.07% <0.00%> (-0.20%) 72.00% <0.00%> (-1.00%)
...a/com/google/cloud/spanner/SessionPoolOptions.java 69.53% <0.00%> (ø) 17.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 213dddc...6d6676f. Read the comment docs.

@olavloite olavloite added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 10, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 10, 2021
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 10, 2021
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 11, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 11, 2021
@olavloite olavloite added the automerge Merge the pull request once unit tests and other checks pass. label Mar 17, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 32fdd60 into master Mar 17, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the auto-config-emulator branch March 17, 2021 09:58
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 17, 2021
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this pull request Nov 17, 2022
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants