fix: wrong use of getRetryDelayInMillis() / 1000 in documentation and retry loops #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: spanner
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #885 +/- ##
============================================
- Coverage 85.20% 85.19% -0.01%
- Complexity 2620 2623 +3
============================================
Files 145 145
Lines 14262 14287 +25
Branches 1378 1379 +1
============================================
+ Hits 12152 12172 +20
- Misses 1538 1539 +1
- Partials 572 576 +4
Continue to review full report at Codecov.
|
elharo
approved these changes
Feb 17, 2021
elharo
approved these changes
Feb 17, 2021
thiagotnunes
approved these changes
Feb 17, 2021
| ErrorCode.ABORTED, "Aborted due to failed initial statement", e)); | ||
| ErrorCode.ABORTED, | ||
| "Aborted due to failed initial statement", | ||
| SpannerExceptionFactory.createAbortedExceptionWithRetryDelay(null, e, 0, 1))); |
There was a problem hiding this comment.
Should we add a non null message here?
There was a problem hiding this comment.
Yes, that's probably better to keep it in line with the other manually constructed Aborted errors.
olavloite
added
the
automerge
|
(Failed samples build is a known flaky test case) |
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Feb 23, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [4.0.1](https://www.github.com/googleapis/java-spanner/compare/v4.0.0...v4.0.1) (2021-02-22) ### Bug Fixes * wrong use of getRetryDelayInMillis() / 1000 in documentation and retry loops ([#885](https://www.github.com/googleapis/java-spanner/issues/885)) ([a55d7ce](https://www.github.com/googleapis/java-spanner/commit/a55d7ce64fff434151c1c3af0796d290e9db7470)), closes [#874](https://www.github.com/googleapis/java-spanner/issues/874) ### Documentation * Add OpenCensus to OpenTelemetry shim to README ([#879](https://www.github.com/googleapis/java-spanner/issues/879)) ([b58d73d](https://www.github.com/googleapis/java-spanner/commit/b58d73ddb768c0d33d149ed8bc84f5af618514e1)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.19.0 ([#895](https://www.github.com/googleapis/java-spanner/issues/895)) ([e3e2c95](https://www.github.com/googleapis/java-spanner/commit/e3e2c95936f40a7954639a95c84cc9495e318e55)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ansh0l
pushed a commit
to ansh0l/java-spanner
that referenced
this pull request
Nov 10, 2022
This is an auto-generated regeneration of the .pb.go files by cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genbot will update the corresponding PR to depend on the newer version of go-genproto, and assign reviewers. Whilst this or any regen PR is open in go-genproto, genbot will not create any more regeneration PRs. If all regen PRs are closed, gapicgen will create a new set of regeneration PRs once per night. If you have been assigned to review this PR, please: - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. That will prompt genbot to assign reviewers to the google-cloud-go PR. Corresponding google-cloud-go PR: googleapis/google-cloud-go#6553 Changes: chore: regenerate API index Source-Link: googleapis/googleapis@f3e6b9f feat(datastream): added support for BigQuery destination and PostgreSQL source types PiperOrigin-RevId: 469482613 Source-Link: googleapis/googleapis@441339a chore: regenerate API index Source-Link: googleapis/googleapis@67e514e feat(aiplatform): add UpsertDatapoints and RemoveDatapoints rpcs to IndexService in aiplatform v1 index_service.proto PiperOrigin-RevId: 469481982 Source-Link: googleapis/googleapis@e4fe55a chore: regenerate API index Source-Link: googleapis/googleapis@95e44ae feat(aiplatform): add UpsertDatapoints and RemoveDatapoints rpcs to IndexService in aiplatform v1beta1 index_service.proto PiperOrigin-RevId: 469481692 Source-Link: googleapis/googleapis@624cc45 chore: regenerate API index Source-Link: googleapis/googleapis@ebed4ae feat(vpcaccess): Adds support for configuring scaling settings Clients can now specify machine type and min/max instances when creating a connector. PiperOrigin-RevId: 469463049 Source-Link: googleapis/googleapis@17b39f1 chore: regenerate API index Source-Link: googleapis/googleapis@fcd2684 feat(retail): release Control and ServingConfig serivces to v2 version feat: release AttributesConfig APIs to v2 version feat: release CompletionConfig APIs to v2 version feat: add local inventories info to the Product resource docs: Improved documentation for Fullfillment and Inventory API in ProductService docs: minor documentation format and typo fixes PiperOrigin-RevId: 469399525 Source-Link: googleapis/googleapis@e9bcb6c
rajatbhatta
pushed a commit
to rajatbhatta/java-spanner
that referenced
this pull request
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the documentation for
TransactionManageras well as some internal retry loops wrongly usedSpannerException#getRetryDelayInMillis() / 1000as input forThread.sleep(long). The retry delay is already in milliseconds and should not be modified.Fixes #874