New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add QueryOptions proto #84
Conversation
Adding a "do not merge" for now since we want to add client library support for some of the updated protos before the API change makes it into a release. |
@@ -11,4 +11,19 @@ | |||
<className>com/google/cloud/spanner/spi/v1/SpannerRpc</className> | |||
<method>* asyncDeleteSession(*)</method> | |||
</difference> | |||
<difference> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @chingor13 I got this binary compatibility error as a result of the auto-generated code so I added them to the list of ignored differences here. Please let me know if you have any concerns about this.
c18326b
to
9130062
Compare
This is an auto-generated interface only intended to be used internally.
The tests are super flaky with the Kokoro builds often not being able to fetch the necessary packages. I've force run these tests three times already and each time a different test fails. @chingor13 are you aware of any issues with our setup that might cause this? |
It happens sometimes when Maven Central downloads are flakey. I'm looking into retry logic on the dependency download but I may not be able to separate the dependency fetching from compilation |
Thanks for looking into this :) I think the retry logic should help given that if I retry it more or less passes. I'm also surprised that I don't have the permissions to force submit. Maybe because I made commits to the PR. |
馃 I have created a release \*beep\* \*boop\* --- ## [1.51.0](https://www.github.com/googleapis/java-spanner/compare/v1.50.0...v1.51.0) (2020-03-13) ### Features * add backend query options ([#90](https://www.github.com/googleapis/java-spanner/issues/90)) ([e96e172](https://www.github.com/googleapis/java-spanner/commit/e96e17246bee9691171b46857806d03d1f8e19b4)) * add QueryOptions proto ([#84](https://www.github.com/googleapis/java-spanner/issues/84)) ([eb8fc37](https://www.github.com/googleapis/java-spanner/commit/eb8fc375bbd766f25966aa565e266ed972bbe818)) ### Bug Fixes * never use credentials in combination with plain text ([#98](https://www.github.com/googleapis/java-spanner/issues/98)) ([7eb8d49](https://www.github.com/googleapis/java-spanner/commit/7eb8d49cd6c35d7f757cb89009ad16be601b77c3)) ### Dependencies * update dependency com.google.cloud:google-cloud-core-bom to v1.93.1 ([#91](https://www.github.com/googleapis/java-spanner/issues/91)) ([29d8db8](https://www.github.com/googleapis/java-spanner/commit/29d8db8cfc9d12824b9264d0fb870049a58a9a03)) * update dependency io.opencensus:opencensus-api to v0.25.0 ([#95](https://www.github.com/googleapis/java-spanner/issues/95)) ([57f5fd0](https://www.github.com/googleapis/java-spanner/commit/57f5fd0f3bee4b437f48b6a08ab3174f035c8cca)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
This PR was generated using Autosynth. 馃寛
Commits in this repo since last synth:
3f32f51 Fix: multiple calls to end of span (#75)
Log from Synthtool