fix: mark transaction as invalid if no tx is returned before close #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osed If a query requests the begin of a new transaction, the transaction id is returned by the first call to ResultSet#next(). If the ResultSet is closed by another thread before the first result has been returned, or before that result has been consumed internally to set the transaction id, no transaction id will be set. This will cause any subsequent statement in the same transaction to timeout while waiting for a transaction to be returned.
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: spanner
Codecov Report
@@ Coverage Diff @@
## master #791 +/- ##
=========================================
Coverage 85.01% 85.01%
- Complexity 2561 2562 +1
=========================================
Files 143 143
Lines 14005 14015 +10
Branches 1337 1341 +4
=========================================
+ Hits 11906 11915 +9
Misses 1537 1537
- Partials 562 563 +1
Continue to review full report at Codecov.
|
thiagotnunes
approved these changes
Jan 12, 2021
thiagotnunes
pushed a commit
that referenced
this pull request
May 6, 2021
…osed (#791) If a query requests the begin of a new transaction, the transaction id is returned by the first call to ResultSet#next(). If the ResultSet is closed by another thread before the first result has been returned, or before that result has been consumed internally to set the transaction id, no transaction id will be set. This will cause any subsequent statement in the same transaction to timeout while waiting for a transaction to be returned.
ansh0l
pushed a commit
to ansh0l/java-spanner
that referenced
this pull request
Nov 10, 2022
This is an auto-generated regeneration of the .pb.go files by cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genbot will update the corresponding PR to depend on the newer version of go-genproto, and assign reviewers. Whilst this or any regen PR is open in go-genproto, genbot will not create any more regeneration PRs. If all regen PRs are closed, gapicgen will create a new set of regeneration PRs once per night. If you have been assigned to review this PR, please: - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. That will prompt genbot to assign reviewers to the google-cloud-go PR. Corresponding google-cloud-go PR: googleapis/google-cloud-go#5865 Changes: chore: regenerate API index Source-Link: googleapis/googleapis@0db710b feat(securitycenter): Add iam_binding field to findings attributes. It represents particular IAM bindings, which captures a member's role addition, removal, or state PiperOrigin-RevId: 439976914 Source-Link: googleapis/googleapis@f83787e docs: explicitly document empty list and search responses PiperOrigin-RevId: 439957204 Source-Link: googleapis/googleapis@fef35d4 chore(dialogflow/cx): remove unused imports PiperOrigin-RevId: 439948451 Source-Link: googleapis/googleapis@1a8770e feat(compute): update compute API to revision 20220322 (googleapis#710) Source-Link: googleapis/googleapis@68ad73b chore: Update disco-to-proto3-converter PiperOrigin-RevId: 439885092 Source-Link: googleapis/googleapis@6d0a5db docs(bigquery/reservation): Mark v1beta1 API as deprecated PiperOrigin-RevId: 439847134 Source-Link: googleapis/googleapis@3255022 chore: regenerate API index Source-Link: googleapis/googleapis@98a98fa chore: remove unused imports PiperOrigin-RevId: 439804516 Source-Link: googleapis/googleapis@ef938a4
rajatbhatta
pushed a commit
to rajatbhatta/java-spanner
that referenced
this pull request
Nov 17, 2022
🤖 I have created a release *beep* *boop* --- ### [2.6.3](googleapis/java-spanner-jdbc@v2.6.2...v2.6.3) (2022-03-29) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.9.0 ([googleapis#789](googleapis/java-spanner-jdbc#789)) ([5fd7287](googleapis/java-spanner-jdbc@5fd7287)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a query requests the begin of a new transaction, the transaction id is returned by the first call to
ResultSet#next(). If theResultSetis closed by another thread before the first result has been returned, or before that result has been consumed internally to set the transaction id, no transaction id will be set. This will cause any subsequent statement in the same transactionto timeout while waiting for a transaction to be returned.