docs: add sample for timeout for one RPC #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a sample for setting a timeout for a single RPC. Fixes GoogleCloudPlatform/java-docs-samples#3805
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
api: spanner
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
|
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
eaball35
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
thiagotnunes
approved these changes
Dec 10, 2020
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
lesv
suggested changes
Dec 11, 2020
samples/snippets/src/main/java/com/example/spanner/StatementTimeoutExample.java
Show resolved
Hide resolved
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Codecov Report
@@ Coverage Diff @@
## master #707 +/- ##
=========================================
Coverage 85.05% 85.05%
Complexity 2556 2556
=========================================
Files 142 142
Lines 13930 13930
Branches 1326 1326
=========================================
Hits 11848 11848
Misses 1526 1526
Partials 556 556 Continue to review full report at Codecov.
|
eaball35
approved these changes
Dec 16, 2020
|
@lesv Would you mind taking a second look at this PR? The PR is currently blocked from merging as you requested changes. |
|
@olavloite Apologies for the delay, what I'm concerned about is that we might test with many PR's / java version tests running at the same time, I'm concerned that you will have collisons. I was probably stuck on table names of Singers & Venues, but that's not really the problem since you are creating an instance and then deleting it. The code in I'm going to release my objection so you can move forward - again I missed the email or I'd have responded earlier. Apologies. If you believe I'm wrong in my concern, feel free to merge, if not could you fix it and explain where my understanding is flawed? |
lesv
approved these changes
Jan 6, 2021
|
I found the discussion. LGTM |
thiagotnunes
pushed a commit
that referenced
this pull request
May 6, 2021
* docs: add sample for timeout for one RPC Adds a sample for setting a timeout for a single RPC. Fixes GoogleCloudPlatform/java-docs-samples#3805 * fix: fix import order * fix: format code with the correct formatter plugin * fix: delete test data after each test * fix: auto-throttle admin requests
ansh0l
pushed a commit
to ansh0l/java-spanner
that referenced
this pull request
Nov 10, 2022
This is an auto-generated regeneration of the .pb.go files by cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genbot will update the corresponding PR to depend on the newer version of go-genproto, and assign reviewers. Whilst this or any regen PR is open in go-genproto, genbot will not create any more regeneration PRs. If all regen PRs are closed, gapicgen will create a new set of regeneration PRs once per night. If you have been assigned to review this PR, please: - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. That will prompt genbot to assign reviewers to the google-cloud-go PR. Corresponding google-cloud-go PR: googleapis/google-cloud-go#5018 Changes: chore(mediatranslation): Update mediatranslation BUILD.bazel package name to google-cloud-media-translation PiperOrigin-RevId: 404908282 Source-Link: googleapis/googleapis@59736be chore(recaptchaenterprise): Update mediatranslation BUILD.bazel package name to google-cloud-recaptcha-enterprise PiperOrigin-RevId: 404908163 Source-Link: googleapis/googleapis@7eea02b docs(dialogflow): clarified meaning of the legacy editions docs: clarified semantic of the streaming APIs PiperOrigin-RevId: 404815104 Source-Link: googleapis/googleapis@bb1f3e9 docs: fix docstring formatting Committer: @parthea PiperOrigin-RevId: 404756337 Source-Link: googleapis/googleapis@f034e5f
rajatbhatta
pushed a commit
to rajatbhatta/java-spanner
that referenced
this pull request
Nov 17, 2022
…jdbc to v2.5.8 (googleapis#707) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-spanner-jdbc](https://togithub.com/googleapis/java-spanner-jdbc) | `2.5.6` -> `2.5.8` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-spanner-jdbc</summary> ### [`v2.5.8`](https://togithub.com/googleapis/java-spanner-jdbc/blob/HEAD/CHANGELOG.md#​258-httpswwwgithubcomgoogleapisjava-spanner-jdbccomparev257v258-2022-01-07) [Compare Source](https://togithub.com/googleapis/java-spanner-jdbc/compare/v2.5.7...v2.5.8) ### [`v2.5.7`](https://togithub.com/googleapis/java-spanner-jdbc/blob/HEAD/CHANGELOG.md#​257-httpswwwgithubcomgoogleapisjava-spanner-jdbccomparev256v257-2022-01-07) [Compare Source](https://togithub.com/googleapis/java-spanner-jdbc/compare/v2.5.6...v2.5.7) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-spanner-jdbc).
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a sample for setting a timeout for a single RPC.
Fixes GoogleCloudPlatform/java-docs-samples#3805