feat: support RPC priority #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olavloite
added
the
do not merge
|
Warning: This pull request is touching the following templated files:
|
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: spanner
|
@thiagotnunes The implementation of this feature should be synchronized with #576 (Tagging), as they both set |
Codecov Report
@@ Coverage Diff @@
## master #676 +/- ##
============================================
+ Coverage 85.10% 85.17% +0.06%
- Complexity 2623 2633 +10
============================================
Files 155 154 -1
Lines 14374 14363 -11
Branches 1340 1342 +2
============================================
Hits 12233 12233
+ Misses 1573 1565 -8
+ Partials 568 565 -3 Continue to review full report at Codecov.
|
thiagotnunes
approved these changes
Dec 2, 2020
google-cloud-spanner/src/main/java/com/google/cloud/spanner/Options.java
Show resolved
Hide resolved
1 task
elharo
suggested changes
Jan 21, 2021
| @@ -406,4 +406,51 @@ | |||
| <className>com/google/cloud/spanner/AbstractLazyInitializer</className> | |||
| <method>java.lang.Object initialize()</method> | |||
| </difference> | |||
|
|
|||
| <!-- RPC Priority --> | |||
| <difference> | |||
There was a problem hiding this comment.
This change will break customers and requires a major version bump. This is not optional.
There was a problem hiding this comment.
This is no longer a breaking change, as the breaking changes that were needed for this and other changes were grouped into a separate change to avoid having to bump the version multiple times. That change added Options... options varargs to the methods that need to support a variety of query / update / transaction options.
|
Warning: This pull request is touching the following templated files:
|
olavloite
force-pushed
the
rpc-priorities
branch
from
3fd0ad2
to
35f26ef
Compare
thiagotnunes
approved these changes
Mar 31, 2021
larkee
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
@elharo Would you mind taking another look at this PR? As your review requested changes, this PR is currently blocked from merging. (FYI: The samples build error is unrelated to this change) |
elharo
approved these changes
Mar 31, 2021
ansh0l
pushed a commit
to ansh0l/java-spanner
that referenced
this pull request
Nov 10, 2022
This is an auto-generated regeneration of the .pb.go files by cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genbot will update the corresponding PR to depend on the newer version of go-genproto, and assign reviewers. Whilst this or any regen PR is open in go-genproto, genbot will not create any more regeneration PRs. If all regen PRs are closed, gapicgen will create a new set of regeneration PRs once per night. If you have been assigned to review this PR, please: - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. That will prompt genbot to assign reviewers to the google-cloud-go PR. Corresponding google-cloud-go PR: googleapis/google-cloud-go#4761 Changes: chore: regenerate API index Source-Link: googleapis/googleapis@d9ac7fa feat(recaptchaenterprise): add GetMetrics and MigrateKey methods to reCAPTCHA enterprise API PiperOrigin-RevId: 396937887 Source-Link: googleapis/googleapis@020672e
rajatbhatta
pushed a commit
to rajatbhatta/java-spanner
that referenced
this pull request
Nov 17, 2022
…onfig to v1.2.2 (googleapis#676) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-shared-config](https://togithub.com/googleapis/java-shared-config) | `1.2.1` -> `1.2.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-shared-config</summary> ### [`v1.2.2`](https://togithub.com/googleapis/java-shared-config/blob/master/CHANGELOG.md#​122-httpswwwgithubcomgoogleapisjava-shared-configcomparev121v122-2021-11-16) [Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v1.2.1...v1.2.2) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-spanner-jdbc).
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for setting RPC priority.