fix: AsyncTransactionManager did not propagate statement errors #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invalid statements or other statements that would cause an error would not cause the returned ApiFuture to fail. Fixes #514
google-cla
bot
added
the
cla: yes
elefeint
approved these changes
Oct 15, 2020
| public void asyncTransactionManager_shouldPropagateStatementFailure() | ||
| throws ExecutionException, InterruptedException, TimeoutException { | ||
| final Statement garbledStatement = | ||
| Statement.newBuilder("INSERT INTO BOOKS (UUID, TITLE) VALUES ('123', 'Test book')jljlk") |
There was a problem hiding this comment.
Optional: use a table more commonly found in client library integration test, so future readers won't have to wonder where BOOKS came from.
product-auto-label
bot
added
the
api: spanner
elefeint
approved these changes
Oct 16, 2020
|
The failing samples test (Java 8) is a known transient error that frequently happens with Kokoro builds. |
ansh0l
pushed a commit
to ansh0l/java-spanner
that referenced
this pull request
Nov 10, 2022
This is an auto-generated regeneration of the .pb.go files by cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genbot will update the corresponding PR to depend on the newer version of go-genproto, and assign reviewers. Whilst this or any regen PR is open in go-genproto, genbot will not create any more regeneration PRs. If all regen PRs are closed, gapicgen will create a new set of regeneration PRs once per night. If you have been assigned to review this PR, please: - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. That will prompt genbot to assign reviewers to the google-cloud-go PR. Corresponding google-cloud-go PR: googleapis/google-cloud-go#3563 Changes: chore: migrate storage to the Python microgenerator Committer: @miraleung PiperOrigin-RevId: 351829553 Source-Link: googleapis/googleapis@09487a7 feat: Publish experimental build files for Google Ads API. PiperOrigin-RevId: 351813340 Source-Link: googleapis/googleapis@bbb3fc4 feat: published Database Migration Service v1 logging SDK PiperOrigin-RevId: 351738225 Source-Link: googleapis/googleapis@92fac3a chore: update gapic-generator ruby to version 0.6.10 PiperOrigin-RevId: 351705536 Source-Link: googleapis/googleapis@89e3c50 feat: added client library for Workflows V1 API PiperOrigin-RevId: 351656488 Source-Link: googleapis/googleapis@5e5da38 fix!(analytics/admin): remove unused fields from `EnhancedMeasurementSettings` fix!: `update_mask` field is required for all Update operations feat: add pagination support for `ListFirebaseLinks` operation fix!: rename `country_code` field to `region_code` in `Account` fix!: rename `url_query_parameter` field to `uri_query_parameter` in `EnhancedMeasurementSettings` fix!: remove `parent` field from `GoogleAdsLink` PiperOrigin-RevId: 351651504 Source-Link: googleapis/googleapis@23e7356 chore: Change proto synchronization tool. PiperOrigin-RevId: 351632373 Source-Link: googleapis/googleapis@2707d2e feat: added client library for Workflows Executions V1 API PiperOrigin-RevId: 351618705 Source-Link: googleapis/googleapis@98911d3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invalid statements or other statements that would cause an error would not cause the returned ApiFuture to fail.
Fixes #514