Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase visibility of #get() #486

Merged
merged 1 commit into from Oct 6, 2020

Conversation

olavloite
Copy link
Collaborator

Increases the visibility of AbstractLazyInitializer#get() to make it usable outside the client library.

Replaces #461.

@olavloite olavloite requested review from a team as code owners September 30, 2020 14:55
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 30, 2020
@thiagotnunes thiagotnunes added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 1, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 1, 2020
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Oct 1, 2020
@codecov
Copy link

codecov bot commented Oct 2, 2020

Codecov Report

Merging #486 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #486   +/-   ##
=========================================
  Coverage     82.20%   82.20%           
- Complexity     2466     2469    +3     
=========================================
  Files           138      138           
  Lines         13631    13631           
  Branches       1312     1312           
=========================================
+ Hits          11205    11206    +1     
  Misses         1896     1896           
+ Partials        530      529    -1     
Impacted Files Coverage Δ Complexity Δ
.../google/cloud/spanner/AbstractLazyInitializer.java 100.00% <ø> (+7.14%) 5.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c13995f...b916df6. Read the comment docs.

Copy link
Contributor

@thiagotnunes thiagotnunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do we have to cut a major for this? @olavloite

@olavloite
Copy link
Collaborator Author

LGTM, do we have to cut a major for this? @olavloite

I would say no. This only adds visibility, so it should not break anything for anyone.

I would also like to reduce the visibility of the initialize method to protected, which would be a breaking change, but I would prefer to include that change with other breaking changes instead of having to cut a major release just for that.

@olavloite olavloite merged commit fa6d964 into master Oct 6, 2020
@olavloite olavloite deleted the increase-visibility-lazyinit-get branch October 6, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants