Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set default values for streaming retry #316

Merged
merged 1 commit into from Jul 6, 2020
Merged

Conversation

olavloite
Copy link
Collaborator

Include default fallback values in case the retry settings are removed or set to values that are invalid (i.e. 0).

@olavloite olavloite requested a review from skuruppu July 1, 2020 17:32
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 1, 2020
@skuruppu skuruppu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 1, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 1, 2020
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 6, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 6, 2020
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 6, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 6, 2020
@olavloite olavloite merged commit 543373b into master Jul 6, 2020
@olavloite olavloite deleted the streaming-retry branch July 6, 2020 18:31
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 7, 2020
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this pull request Nov 17, 2022
Some applications that load multiple JDBC drivers may run into dependency
conflicts if other JDBC drivers use the same dependencies but different
versions. This problem can be mitigated by creating a jar with shaded
dependencies. This change adds a Maven profile for creating shaded jars.

Fixes googleapis#316
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants