Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run samples test on both Java 8 and Java 11 #283

Closed
olavloite opened this issue Jun 18, 2020 · 8 comments
Closed

Run samples test on both Java 8 and Java 11 #283

olavloite opened this issue Jun 18, 2020 · 8 comments
Assignees
Labels
api: spanner Issues related to the googleapis/java-spanner API. type: process A process-related concern. May include testing, release, or the like.

Comments

@olavloite
Copy link
Collaborator

olavloite commented Jun 18, 2020

The Spanner sample tests should be executed on both Java 8 and Java 11, as some dependencies are only included in Java 9 and higher. This has caused broken builds in Java 9 and higher to pass without notice.

See also #280

@olavloite olavloite added type: process A process-related concern. May include testing, release, or the like. api: spanner Issues related to the googleapis/java-spanner API. labels Jun 18, 2020
@olavloite
Copy link
Collaborator Author

@chingor13 Is this something you could help with? I do not know how to add an additional Kokoro build to execute the Samples test on both Java 8 and Java 11.

@skuruppu
Copy link
Contributor

skuruppu commented Jul 8, 2020

I can help out with this. I'm trying to understand the Kokoro configs and will get back to you once I learn how this is setup.

@skuruppu skuruppu self-assigned this Jul 8, 2020
@thiagotnunes thiagotnunes self-assigned this Jul 13, 2020
@thiagotnunes
Copy link
Contributor

@skuruppu @olavloite the sample test badges are not shown in the README file as well, should we add them or is that going to be confusing?

@olavloite
Copy link
Collaborator Author

@thiagotnunes Those test badges are automatically generated for all Java clients for the different Google Cloud projects here: https://github.com/googleapis/synthtool/tree/master/synthtool/gcp/templates/java_library

So if we were to change that, we would have to change it for all Java clients.

I don't feel very strongly either way about this.

@thiagotnunes
Copy link
Contributor

Got it, thanks @olavloite. I will refrain from changing the badges now due to the impact of the change. I will follow up on this decision with @skuruppu.

@olavloite
Copy link
Collaborator Author

@thiagotnunes Can this issue be closed now that #345 has been merged?

@thiagotnunes
Copy link
Contributor

@olavloite not yet, I still need to do something in the backend to enable the tests. Hopefully today it will get sorted out and I will close #345.

@thiagotnunes
Copy link
Contributor

We should now see the samples tests for java8 and java11 being run in kokoro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

No branches or pull requests

3 participants