Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for CallCredentials #26

Merged
merged 2 commits into from Jan 14, 2020
Merged

feat: add support for CallCredentials #26

merged 2 commits into from Jan 14, 2020

Conversation

olavloite
Copy link
Collaborator

Adds support for using CallCredentials that could vary per call instead of only static credentials passed in at startup.

Fixes #18

Adds support for using CallCredentials that could vary per call
instead of only static credentials passed in at startup.

Fixes #18
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 10, 2020
@olavloite olavloite added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Jan 13, 2020
@Capstan
Copy link

Capstan commented Jan 13, 2020

LGTM. I believe this would work for our purposes.

Copy link
Contributor

@hengfengli hengfengli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 👍

@olavloite olavloite merged commit 1112357 into master Jan 14, 2020
@olavloite olavloite deleted the call-credentials branch January 14, 2020 08:44
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this pull request Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How do I apply a io.grpc.CallCredentials to ServiceOptions?
4 participants