New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to GitHub actions for unit tests #219

Closed

chingor13 opened this issue May 15, 2020 · 2 comments

Assignees

Labels

api: spanner priority: p2 type: process

Contributor

chingor13 commented May 15, 2020

It looks like the Spanner units need a few environment variables set which we are not providing currently (GOOGLE_CLOUD_PROJECT and maybe others?) See #218

We can look into globally adding some environment variables for the unit tests, or look into mechanisms for selectively added environment variables.

Note: integration & sample tests are unaffected

chingor13 added the type: process label

product-auto-label bot added the api: spanner label

olavloite mentioned this issue

fix: remove the need for any env var in all tests #235

Merged

hengfengli assigned olavloite

Contributor

hengfengli commented May 25, 2020

@olavloite Has this issue been resolved?

hengfengli added the priority: p2 label

Collaborator

olavloite commented May 26, 2020

@hengfengli Yes, this was fixed in #235

olavloite closed this as completed

rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this issue


          deps: update dependency com.google.cloud:google-cloud-shared-dependen…

0ab5c5b

…cies to v0.10.0 (googleapis#219)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [com.google.cloud:google-cloud-shared-dependencies](https://togithub.com/googleapis/java-shared-dependencies) | minor | `0.9.0` -> `0.10.0` |

---

### Release Notes

<details>
<summary>googleapis/java-shared-dependencies</summary>

### [`v0.10.0`](https://togithub.com/googleapis/java-shared-dependencies/blob/master/CHANGELOG.md#&#8203;0100-httpswwwgithubcomgoogleapisjava-shared-dependenciescompare091v0100-2020-09-23)

[Compare Source](https://togithub.com/googleapis/java-shared-dependencies/compare/v0.9.1...v0.10.0)

##### Features

-   manage error-prone version ([#&#8203;147](https://www.github.com/googleapis/java-shared-dependencies/issues/147)) ([0fb3108](https://www.github.com/googleapis/java-shared-dependencies/commit/0fb3108c96abcdef83b5051e842530e6c9934c37))

##### Dependencies

-   update google.core.version to v1.93.9 ([#&#8203;148](https://www.github.com/googleapis/java-shared-dependencies/issues/148)) ([b2a680e](https://www.github.com/googleapis/java-shared-dependencies/commit/b2a680ec9297136dceb622463672cc554359ba5b))

##### [0.9.1](https://www.github.com/googleapis/java-shared-dependencies/compare/0.9.0...v0.9.1) (2020-09-23)

##### Dependencies

-   update dependency io.grpc:grpc-bom to v1.32.1 ([#&#8203;133](https://www.github.com/googleapis/java-shared-dependencies/issues/133)) ([cde0463](https://www.github.com/googleapis/java-shared-dependencies/commit/cde0463dd15c2a510085a3d5e3ac7b418c2fc3d4))
-   update iam.version to v1.0.1 ([#&#8203;136](https://www.github.com/googleapis/java-shared-dependencies/issues/136)) ([162e2bd](https://www.github.com/googleapis/java-shared-dependencies/commit/162e2bda35fc3427ce571c6747aae4c9eb5866f6))

### [`v0.9.1`](https://togithub.com/googleapis/java-shared-dependencies/blob/master/CHANGELOG.md#&#8203;091-httpswwwgithubcomgoogleapisjava-shared-dependenciescompare090v091-2020-09-23)

[Compare Source](https://togithub.com/googleapis/java-shared-dependencies/compare/v0.9.0...v0.9.1)

</details>

---

### Renovate configuration

:date: **Schedule**: At any time (no schedule defined).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-spanner-jdbc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment