Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a way to specify timeout and retry for transaction. #1900

Closed
yuanyuan-gl opened this issue May 27, 2022 · 3 comments
Closed

Need a way to specify timeout and retry for transaction. #1900

yuanyuan-gl opened this issue May 27, 2022 · 3 comments
Assignees
Labels
api: spanner Issues related to the googleapis/java-spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@yuanyuan-gl
Copy link

Currently the entire transaction is continually retied for 24 hours according to #1009.

I think this could get dataflow jobs to stuck or run for long time. Also if the transaction finally get retried successfully after 23 hours, it doesn't give any error or information for customer to debug the issue from their end.

For example, I have saw one case, transactions have been retried for 24 hours again and again due to following error and dataflow jobs gets stuck due to this :

Error message from worker: com.google.cloud.spanner.AbortedException: ABORTED: io.grpc.StatusRuntimeException: ABORTED: Transaction was aborted. Idle for over 10 seconds. retry_delay { seconds: 254 nanos: 433062132 }

Does it make sense support custom retry and timeout settings on the transaction retry?

@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label May 27, 2022
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label May 28, 2022
@ansh0l ansh0l added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels May 30, 2022
@ansh0l ansh0l assigned rajatbhatta and unassigned ansh0l May 30, 2022
@ansh0l ansh0l added the priority: p2 Moderately-important priority. Fix may not be included in next release. label May 30, 2022
@siddharth-anvekar
Copy link

Any latest update on this?

@rajatbhatta rajatbhatta assigned arpan14 and unassigned rajatbhatta Aug 17, 2023
@olavloite
Copy link
Collaborator

@yuanyuan-gl @siddharth-anvekar We've added a sample for how you can set a transaction timeout here:

Does that work for your use case?

@arpan14
Copy link
Collaborator

arpan14 commented Jan 12, 2024

Please feel free to re-open if issue still persists.

@arpan14 arpan14 closed this as completed Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

7 participants