Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provision more channels with fewer sessions in each when using gRPC-GCP channel pool #1566

Closed
skuruppu opened this issue Dec 2, 2021 · 1 comment · Fixed by #1997
Closed

Provision more channels with fewer sessions in each when using gRPC-GCP channel pool #1566

skuruppu opened this issue Dec 2, 2021 · 1 comment · Fixed by #1997
Labels
api: spanner Issues related to the googleapis/java-spanner API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@skuruppu
Copy link
Contributor

skuruppu commented Dec 2, 2021

#1227 introduced an option to use the gRPC-GCP channel pool. When using this pool, to make sure there are sufficient channels available to move the sessions to a different channel if a network connection in a particular channel fails, it's recommended that each channel try to only support ~50 concurrent requests.

Currently, we have 4 channels by default, with max sessions = 400 so that each channel likely has at most 100 sessions.

So this request is to double the number of channels initialized (to 8) if the gRPC-GCP channel pool is being used.
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Dec 2, 2021
@skuruppu skuruppu added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Dec 2, 2021
@skuruppu skuruppu assigned ansh0l and unassigned thiagotnunes Dec 7, 2021
@ansh0l ansh0l assigned rajatbhatta and unassigned ansh0l Apr 14, 2022
@ansh0l
Copy link
Member

ansh0l commented Aug 23, 2022

cc @harshachinta

@harshachinta harshachinta mentioned this issue Sep 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/java-spanner API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
4 participants
@thiagotnunes @skuruppu @ansh0l @rajatbhatta