fix: keep track of any BeginTransaction option for a Read #1485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a StreamingReadRequest that included a BeginTransaction option was retried as a result of a transient error (UNAVAILABLE), the fact that the BeginTransaction option was included would not be registered for the retried request. This could cause a transaction to fail if the retried request returned an Aborted error, and that Aborted error was caught by the application.
product-auto-label
bot
added
the
api: spanner
google-cla
bot
added
the
cla: yes
thiagotnunes
approved these changes
Oct 6, 2021
gcf-owl-bot bot
added a commit
that referenced
this pull request
Jul 13, 2022
Source-Link: googleapis/synthtool@7336562 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:d4b80feffe1579818cdc39466152e9de95789a193408506cd4a1ffbe8804dc00
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jul 13, 2022
Source-Link: googleapis/synthtool@7336562 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:d4b80feffe1579818cdc39466152e9de95789a193408506cd4a1ffbe8804dc00
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jul 14, 2022
🤖 I have created a release *beep* *boop* --- ## [6.26.0](v6.25.7...v6.26.0) (2022-07-13) ### Features * Adding two new fields for Instance create_time and update_time ([#1908](#1908)) ([00b3817](00b3817)) * changes to support data, timestamp and arrays in IT tests ([#1840](#1840)) ([c667653](c667653)) * Error Details Improvement ([c8a2184](c8a2184)) * Error Details Improvement ([#1929](#1929)) ([c8a2184](c8a2184)) ### Bug Fixes * enable longpaths support for windows test ([#1485](#1485)) ([#1946](#1946)) ([fd0b845](fd0b845)) ### Dependencies * update dependency com.google.cloud:google-cloud-trace to v2.3.0 ([#1934](#1934)) ([2813eb2](2813eb2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
rajatbhatta
pushed a commit
to rajatbhatta/java-spanner
that referenced
this pull request
Nov 17, 2022
…gleapis#908) Source-Link: googleapis/synthtool@7336562 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:d4b80feffe1579818cdc39466152e9de95789a193408506cd4a1ffbe8804dc00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a StreamingReadRequest that included a BeginTransaction option was retried as a result
of a transient error (UNAVAILABLE), the fact that the BeginTransaction option was included
would not be registered for the retried request. This could cause a transaction to fail if
the retried request returned an Aborted error, and that Aborted error was caught by the
application.