Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix JSON sample test #1417

Merged
merged 3 commits into from Sep 9, 2021
Merged

fix: fix JSON sample test #1417

merged 3 commits into from Sep 9, 2021

Conversation

zoercai
Copy link
Contributor

@zoercai zoercai commented Sep 9, 2021

No description provided.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 9, 2021
@product-auto-label product-auto-label bot added api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. labels Sep 9, 2021
@zoercai zoercai changed the title fix: escape " in JSON sample fix: add " in JSON sample Sep 9, 2021
@zoercai zoercai changed the title fix: add " in JSON sample fix: fix JSON sample test Sep 9, 2021
@zoercai zoercai marked this pull request as ready for review September 9, 2021 04:00
@zoercai zoercai requested a review from a team as a code owner September 9, 2021 04:00
@zoercai zoercai merged commit dc1f9a9 into googleapis:master Sep 9, 2021
@zoercai zoercai deleted the fix-json-sample-test branch September 9, 2021 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagotnunes thiagotnunes thiagotnunes approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/java-spanner API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zoercai @thiagotnunes