Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for custom ExecutorProvider in SpannerOptions.Builder #1262

Closed
pravsingh opened this issue Jun 28, 2021 · 1 comment · Fixed by #1263
Closed

support for custom ExecutorProvider in SpannerOptions.Builder #1262

pravsingh opened this issue Jun 28, 2021 · 1 comment · Fixed by #1263
Assignees
Labels
api: spanner Issues related to the googleapis/java-spanner API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@pravsingh
Copy link

Is your feature request related to a problem? Please describe.
I would like to configure ExecutorProvider in SpannerOptions so can control the executor configs. Currently the Builder doesn't provide any setter for it. Due to this, the asyncExecutorProvider is null and hence the below code always falls back to the default provider:

SpannerImpl(SpannerRpc gapicRpc, SpannerOptions options) {
...

    this.asyncExecutorProvider =
        MoreObjects.firstNonNull(
            options.getAsyncExecutorProvider(),
            SpannerOptions.createDefaultAsyncExecutorProvider());
...
}

Describe the solution you'd like
Add setter in SpannerOptions.Builder class.

Describe alternatives you've considered
So far found no alternative.

Additional context
Discussed about this issue at discussion

@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Jun 28, 2021
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Jun 29, 2021
@thiagotnunes
Copy link
Contributor

@olavloite Could you take a look at this? I think you were already following this issue before.

@olavloite olavloite added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants