New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: plain text when testing emulator connection #1020
Conversation
Uses plain text, instead of ssl when testing for local connections.
Codecov Report
@@ Coverage Diff @@
## master #1020 +/- ##
============================================
- Coverage 85.12% 85.10% -0.02%
+ Complexity 2627 2623 -4
============================================
Files 155 155
Lines 14369 14374 +5
Branches 1340 1340
============================================
+ Hits 12231 12233 +2
- Misses 1571 1573 +2
- Partials 567 568 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noticing that one!
🤖 I have created a release *beep* *boop* --- ## [2.7.11](https://togithub.com/googleapis/java-spanner-jdbc/compare/v2.7.10...v2.7.11) (2022-10-20) ### Dependencies * Update dependency org.graalvm.buildtools:junit-platform-native to v0.9.16 ([googleapis#1017](https://togithub.com/googleapis/java-spanner-jdbc/issues/1017)) ([ee7888c](https://togithub.com/googleapis/java-spanner-jdbc/commit/ee7888c1720aa84ca2d4278a9e52f111c298ea9d)) * Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.16 ([googleapis#1018](https://togithub.com/googleapis/java-spanner-jdbc/issues/1018)) ([3d5b100](https://togithub.com/googleapis/java-spanner-jdbc/commit/3d5b1004eb3d4e61f954b523ef2c45d59f0fbfe0)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Uses plain text, instead of ssl when testing for local connections. This fixes connection checks when using the
MockSpannerServiceImpl
and it works with the emulator as well.Without this fix we would get a transport error when testing the
getConnection
when using theMockSpannerServiceImpl
, since the client would expectTLS
, while the server would be servingplainText
.