New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improve error messages #1011
Conversation
Improve error messages when something is wrong in the connection string. Fixes #java-spanner-jdbc/399
cc @jimmyruska |
Codecov Report
@@ Coverage Diff @@
## master #1011 +/- ##
============================================
- Coverage 85.14% 85.06% -0.09%
- Complexity 2622 2623 +1
============================================
Files 154 154
Lines 14329 14362 +33
Branches 1334 1340 +6
============================================
+ Hits 12201 12217 +16
- Misses 1565 1576 +11
- Partials 563 569 +6
Continue to review full report at Codecov.
|
* Executes a quick check to see if this connection can actually connect to a local emulator host | ||
* or other (mock) test server, if the options point to localhost instead of Cloud Spanner. | ||
*/ | ||
private void checkLocalConnection() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we extract a class for this? I feel this class is very big already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I've moved it to a separate class.
🤖 I have created a release *beep* *boop* --- ## [2.7.10](https://togithub.com/googleapis/java-spanner-jdbc/compare/v2.7.9...v2.7.10) (2022-10-18) ### Dependencies * Update dependency org.graalvm.buildtools:junit-platform-native to v0.9.15 ([googleapis#1009](https://togithub.com/googleapis/java-spanner-jdbc/issues/1009)) ([8a6da6c](https://togithub.com/googleapis/java-spanner-jdbc/commit/8a6da6cbd95a23f6601775fb7147567ca1017119)) * Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.15 ([googleapis#1010](https://togithub.com/googleapis/java-spanner-jdbc/issues/1010)) ([b686d20](https://togithub.com/googleapis/java-spanner-jdbc/commit/b686d20f86f2408d714e8e0335332635f10971cb)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Improve error messages when something is wrong in the connection string.
Fixes googleapis/java-spanner-jdbc#399