Skip to content

Commit

Permalink
fix: ignore added interface methods for generated code (#101)
Browse files Browse the repository at this point in the history
Adds generic ignore rules for added methods to interfaces in the generated code.

Fixes #99
  • Loading branch information
olavloite committed Mar 16, 2020
1 parent 37b7c88 commit 402cfa1
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 39 deletions.
@@ -1,34 +1,10 @@
<?xml version="1.0" encoding="UTF-8"?>
<!-- see http://www.mojohaus.org/clirr-maven-plugin/examples/ignored-differences.html -->
<differences>
<!-- Ignore all new methods in interfaces in the generated code. -->
<difference>
<differenceType>7012</differenceType>
<className>com/google/spanner/admin/database/v1/DatabaseOrBuilder</className>
<method>* getCreateTime()</method>
</difference>
<difference>
<differenceType>7012</differenceType>
<className>com/google/spanner/admin/database/v1/DatabaseOrBuilder</className>
<method>* getCreateTimeOrBuilder()</method>
</difference>
<difference>
<differenceType>7012</differenceType>
<className>com/google/spanner/admin/database/v1/DatabaseOrBuilder</className>
<method>* getRestoreInfo()</method>
</difference>
<difference>
<differenceType>7012</differenceType>
<className>com/google/spanner/admin/database/v1/DatabaseOrBuilder</className>
<method>* getRestoreInfoOrBuilder()</method>
</difference>
<difference>
<differenceType>7012</differenceType>
<className>com/google/spanner/admin/database/v1/DatabaseOrBuilder</className>
<method>* hasCreateTime()</method>
</difference>
<difference>
<differenceType>7012</differenceType>
<className>com/google/spanner/admin/database/v1/DatabaseOrBuilder</className>
<method>* hasRestoreInfo()</method>
<className>com/google/spanner/admin/database/v1/*</className>
<method>*</method>
</difference>
</differences>
@@ -0,0 +1,10 @@
<?xml version="1.0" encoding="UTF-8"?>
<!-- see http://www.mojohaus.org/clirr-maven-plugin/examples/ignored-differences.html -->
<differences>
<!-- Ignore all new methods in interfaces in the generated code. -->
<difference>
<differenceType>7012</differenceType>
<className>com/google/spanner/admin/instance/v1/*</className>
<method>*</method>
</difference>
</differences>
15 changes: 3 additions & 12 deletions proto-google-cloud-spanner-v1/clirr-ignored-differences.xml
@@ -1,19 +1,10 @@
<?xml version="1.0" encoding="UTF-8"?>
<!-- see http://www.mojohaus.org/clirr-maven-plugin/examples/ignored-differences.html -->
<differences>
<!-- Ignore all new methods in interfaces in the generated code. -->
<difference>
<differenceType>7012</differenceType>
<className>com/google/spanner/v1/ExecuteSqlRequestOrBuilder</className>
<method>* getQueryOptions()</method>
</difference>
<difference>
<differenceType>7012</differenceType>
<className>com/google/spanner/v1/ExecuteSqlRequestOrBuilder</className>
<method>* getQueryOptionsOrBuilder()</method>
</difference>
<difference>
<differenceType>7012</differenceType>
<className>com/google/spanner/v1/ExecuteSqlRequestOrBuilder</className>
<method>* hasQueryOptions()</method>
<className>com/google/spanner/v1/*</className>
<method>*</method>
</difference>
</differences>

0 comments on commit 402cfa1

Please sign in to comment.