From 2d19c25ba32847d116194565e67e1b1276fcb9f8 Mon Sep 17 00:00:00 2001 From: skuruppu Date: Fri, 8 May 2020 21:08:05 +1000 Subject: [PATCH] fix: make it possible to override backups methods (#195) Currently `restoreDatabase`, `updateBackup` and `deleteBackup` are final methods. For some internal tests, we need to override these methods so ideally they shouldn't be final. --- .../com/google/cloud/spanner/spi/v1/GapicSpannerRpc.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/GapicSpannerRpc.java b/google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/GapicSpannerRpc.java index 0d35a04c01..181a09d6c7 100644 --- a/google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/GapicSpannerRpc.java +++ b/google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/GapicSpannerRpc.java @@ -853,7 +853,7 @@ public Timestamp apply(Operation input) { } @Override - public final OperationFuture restoreDatabase( + public OperationFuture restoreDatabase( final String databaseInstanceName, final String databaseId, String backupName) { RestoreDatabaseRequest request = RestoreDatabaseRequest.newBuilder() @@ -905,7 +905,7 @@ public Timestamp apply(Operation input) { } @Override - public final Backup updateBackup(Backup backup, FieldMask updateMask) { + public Backup updateBackup(Backup backup, FieldMask updateMask) { acquireAdministrativeRequestsRateLimiter(); UpdateBackupRequest request = UpdateBackupRequest.newBuilder().setBackup(backup).setUpdateMask(updateMask).build(); @@ -914,7 +914,7 @@ public final Backup updateBackup(Backup backup, FieldMask updateMask) { } @Override - public final void deleteBackup(String backupName) { + public void deleteBackup(String backupName) { acquireAdministrativeRequestsRateLimiter(); DeleteBackupRequest request = DeleteBackupRequest.newBuilder().setName(backupName).build(); GrpcCallContext context = newCallContext(null, backupName);