From 213dddcb4f84e19be2f98115493208e3af819485 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Knut=20Olav=20L=C3=B8ite?= Date: Wed, 17 Mar 2021 00:51:06 +0100 Subject: [PATCH] fix: all throwables should be ignored in shutdown hook (#950) All throwables (and not just exceptions) should be ignored in the shutdown hook. Failing to close these resources during shutdown is not a major problem, as they will be garbage collected by the backend anyways. Without this wide catch, some applications will log a ClassNotFoundException when shutting down, which can be confusing for end users. Fixes #949 --- .../java/com/google/cloud/spanner/connection/SpannerPool.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/google-cloud-spanner/src/main/java/com/google/cloud/spanner/connection/SpannerPool.java b/google-cloud-spanner/src/main/java/com/google/cloud/spanner/connection/SpannerPool.java index 51bfde8f00..132478b364 100644 --- a/google-cloud-spanner/src/main/java/com/google/cloud/spanner/connection/SpannerPool.java +++ b/google-cloud-spanner/src/main/java/com/google/cloud/spanner/connection/SpannerPool.java @@ -104,7 +104,7 @@ private final class CloseSpannerRunnable implements Runnable { public void run() { try { checkAndCloseSpanners(CheckAndCloseSpannersMode.WARN); - } catch (Exception e) { + } catch (Throwable e) { // ignore } }