From 1817afade2005d3a3dbf61e25d096767b2ebfcb3 Mon Sep 17 00:00:00 2001
From: Olav Loite <koloite@gmail.com>
Date: Thu, 30 Jul 2020 20:57:02 +0200
Subject: [PATCH] test: constraint error causes transaction to be invalidated

---
 .../cloud/spanner/it/ITTransactionTest.java   | 39 +++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITTransactionTest.java b/google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITTransactionTest.java
index 6073aad39a..57d8e085c6 100644
--- a/google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITTransactionTest.java
+++ b/google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITTransactionTest.java
@@ -578,6 +578,45 @@ public Long run(TransactionContext transaction) throws Exception {
     assertThat(updateCount).isEqualTo(1L);
   }
 
+  @Test
+  public void testTxWithConstraintError() {
+    assumeFalse(
+        "Emulator does not recover from an error within a transaction",
+        env.getTestHelper().isEmulator());
+
+    // First insert a single row.
+    client.writeAtLeastOnce(
+        ImmutableList.of(
+            Mutation.newInsertOrUpdateBuilder("T").set("K").to("One").set("V").to(1L).build()));
+
+    long updateCount =
+        client
+            .readWriteTransaction()
+            .run(
+                new TransactionCallable<Long>() {
+                  @Override
+                  public Long run(TransactionContext transaction) throws Exception {
+                    try {
+                      // Try to insert a duplicate row. This statement will fail. When the statement
+                      // is executed against an already existing transaction (i.e.
+                      // inlineBegin=false), the entire transaction will remain invalid and cannot
+                      // be committed. When it is executed as the first statement of a transaction
+                      // that also tries to start a transaction, then no transaction will be started
+                      // and the next statement will start the transaction. This will cause the
+                      // transaction to succeed.
+                      transaction.executeUpdate(
+                          Statement.of("INSERT INTO T (K, V) VALUES ('One', 1)"));
+                      fail("missing expected exception");
+                    } catch (SpannerException e) {
+                      assertThat(e.getErrorCode()).isEqualTo(ErrorCode.ALREADY_EXISTS);
+                    }
+                    return transaction.executeUpdate(
+                        Statement.of("INSERT INTO T (K, V) VALUES ('Two', 2)"));
+                  }
+                });
+    assertThat(updateCount).isEqualTo(1L);
+  }
+
   @Test
   public void testTxWithUncaughtError() {
     try {