From 0528b8cf7a8dff51a4b3f3053d20475a9810f6c1 Mon Sep 17 00:00:00 2001
From: Thiago Nunes <thiagotnunes@google.com>
Date: Fri, 2 Oct 2020 09:09:18 +1000
Subject: [PATCH] fix: closes result set in test

Addresses PR comment.
---
 .../spanner/it/ITPitrUpdateDatabaseTest.java      | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITPitrUpdateDatabaseTest.java b/google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITPitrUpdateDatabaseTest.java
index e4130fe67ad..4fd34aeac2e 100644
--- a/google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITPitrUpdateDatabaseTest.java
+++ b/google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITPitrUpdateDatabaseTest.java
@@ -120,21 +120,22 @@ public void returnsTheVersionRetentionPeriodSetThroughGetDatabaseDdl() {
 
   @Test
   public void returnsTheVersionRetentionPeriodSetThroughInformationSchema() {
-    final ResultSet rs =
+    try (final ResultSet rs =
         dbClient
             .singleUse()
             .executeQuery(
                 Statement.of(
                     "SELECT OPTION_VALUE AS version_retention_period "
                         + "FROM INFORMATION_SCHEMA.DATABASE_OPTIONS "
-                        + "WHERE SCHEMA_NAME = '' AND OPTION_NAME = 'version_retention_period'"));
+                        + "WHERE SCHEMA_NAME = '' AND OPTION_NAME = 'version_retention_period'"))) {
 
-    String versionRetentionPeriod = null;
-    while (rs.next()) {
-      versionRetentionPeriod = rs.getString("version_retention_period");
-    }
+      String versionRetentionPeriod = null;
+      while (rs.next()) {
+        versionRetentionPeriod = rs.getString("version_retention_period");
+      }
 
-    assertThat(versionRetentionPeriod).isEqualTo(VERSION_RETENTION_PERIOD);
+      assertThat(versionRetentionPeriod).isEqualTo(VERSION_RETENTION_PERIOD);
+    }
   }
 
   @Test