Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: publish shaded jar on maven central #83

Merged
merged 3 commits into from May 27, 2020
Merged

Conversation

olavloite
Copy link
Collaborator

This is a copy of googleapis/google-cloud-java#6957.

Includes the shaded Spanner JDBC jar in the standard build for the library and publishes it to Maven central with a classifier. This makes the shaded jar downloadable directly from Maven, instead of requiring users to build the jar themselves. It also makes it possible to add automated tests for whether the shaded jar works or not.

The profile build-jdbc-driver is removed and the execution of the shade build goal that was part of the profile is moved into the default build profile. This ensures that the shaded jar is always built.

Fixes #22

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 10, 2020
@codecov
Copy link

codecov bot commented Mar 10, 2020

Codecov Report

Merging #83 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #83   +/-   ##
=========================================
  Coverage     71.95%   71.95%           
  Complexity     1027     1027           
=========================================
  Files            24       24           
  Lines          3156     3156           
  Branches        463      463           
=========================================
  Hits           2271     2271           
  Misses          706      706           
  Partials        179      179           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03166fa...9d494a5. Read the comment docs.

@olavloite olavloite merged commit 2a7c53e into master May 27, 2020
@olavloite olavloite deleted the publish-shaded-jar branch May 27, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spanner JDBC Driver - Provider io.grpc.netty.shaded.io.grpc.netty.NettyChannelProvider not a subtype
3 participants