Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spanner-jdbc: Unable to update JDBC driver to depend on latest spanner version #59

Closed
skuruppu opened this issue Feb 13, 2020 · 0 comments · Fixed by #63
Closed

spanner-jdbc: Unable to update JDBC driver to depend on latest spanner version #59

skuruppu opened this issue Feb 13, 2020 · 0 comments · Fixed by #63
Assignees
@olavloite
Labels
api: spanner Issues related to the googleapis/java-spanner-jdbc API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: question Request for information or clarification. Not an issue.

Comments

@skuruppu
Copy link
Contributor

PR #28 is failing builds with the following errors:

[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /tmpfs/src/github/java-spanner-jdbc/src/test/java/com/google/cloud/spanner/jdbc/JdbcAbortedTransactionTest.java:[126,16] cannot access com.google.spanner.v1.SpannerGrpc
  class file for com.google.spanner.v1.SpannerGrpc not found
[ERROR] /tmpfs/src/github/java-spanner-jdbc/src/test/java/com/google/cloud/spanner/jdbc/JdbcAbortedTransactionTest.java:[134,13] no suitable method found for addService(com.google.cloud.spanner.MockSpannerServiceImpl)
    method io.grpc.ServerBuilder.addService(io.grpc.ServerServiceDefinition) is not applicable
      (argument mismatch; com.google.cloud.spanner.MockSpannerServiceImpl cannot be converted to io.grpc.ServerServiceDefinition)
    method io.grpc.ServerBuilder.addService(io.grpc.BindableService) is not applicable
      (argument mismatch; com.google.cloud.spanner.MockSpannerServiceImpl cannot be converted to io.grpc.BindableService)
    method io.grpc.internal.AbstractServerImplBuilder.addService(io.grpc.ServerServiceDefinition) is not applicable
      (argument mismatch; com.google.cloud.spanner.MockSpannerServiceImpl cannot be converted to io.grpc.ServerServiceDefinition)
    method io.grpc.internal.AbstractServerImplBuilder.addService(io.grpc.BindableService) is not applicable
      (argument mismatch; com.google.cloud.spanner.MockSpannerServiceImpl cannot be converted to io.grpc.BindableService)
[ERROR] /tmpfs/src/github/java-spanner-jdbc/src/test/java/com/google/cloud/spanner/jdbc/JdbcDriverTest.java:[60,52] no suitable method found for addService(com.google.cloud.spanner.MockSpannerServiceImpl)
    method io.grpc.ServerBuilder.addService(io.grpc.ServerServiceDefinition) is not applicable
      (argument mismatch; com.google.cloud.spanner.MockSpannerServiceImpl cannot be converted to io.grpc.ServerServiceDefinition)
    method io.grpc.ServerBuilder.addService(io.grpc.BindableService) is not applicable
      (argument mismatch; com.google.cloud.spanner.MockSpannerServiceImpl cannot be converted to io.grpc.BindableService)
    method io.grpc.internal.AbstractServerImplBuilder.addService(io.grpc.ServerServiceDefinition) is not applicable
      (argument mismatch; com.google.cloud.spanner.MockSpannerServiceImpl cannot be converted to io.grpc.ServerServiceDefinition)
    method io.grpc.internal.AbstractServerImplBuilder.addService(io.grpc.BindableService) is not applicable
      (argument mismatch; com.google.cloud.spanner.MockSpannerServiceImpl cannot be converted to io.grpc.BindableService)
[ERROR] /tmpfs/src/github/java-spanner-jdbc/src/test/java/com/google/cloud/spanner/jdbc/AbortedTest.java:[101,13] no suitable method found for addService(com.google.cloud.spanner.MockSpannerServiceImpl)
    method io.grpc.ServerBuilder.addService(io.grpc.ServerServiceDefinition) is not applicable
      (argument mismatch; com.google.cloud.spanner.MockSpannerServiceImpl cannot be converted to io.grpc.ServerServiceDefinition)
    method io.grpc.ServerBuilder.addService(io.grpc.BindableService) is not applicable
      (argument mismatch; com.google.cloud.spanner.MockSpannerServiceImpl cannot be converted to io.grpc.BindableService)
    method io.grpc.internal.AbstractServerImplBuilder.addService(io.grpc.ServerServiceDefinition) is not applicable
      (argument mismatch; com.google.cloud.spanner.MockSpannerServiceImpl cannot be converted to io.grpc.ServerServiceDefinition)
    method io.grpc.internal.AbstractServerImplBuilder.addService(io.grpc.BindableService) is not applicable
      (argument mismatch; com.google.cloud.spanner.MockSpannerServiceImpl cannot be converted to io.grpc.BindableService)
[ERROR] /tmpfs/src/github/java-spanner-jdbc/src/test/java/com/google/cloud/spanner/jdbc/JdbcDatabaseMetaDataWithMockedServerTest.java:[76,52] no suitable method found for addService(com.google.cloud.spanner.MockSpannerServiceImpl)
    method io.grpc.ServerBuilder.addService(io.grpc.ServerServiceDefinition) is not applicable
      (argument mismatch; com.google.cloud.spanner.MockSpannerServiceImpl cannot be converted to io.grpc.ServerServiceDefinition)
    method io.grpc.ServerBuilder.addService(io.grpc.BindableService) is not applicable
      (argument mismatch; com.google.cloud.spanner.MockSpannerServiceImpl cannot be converted to io.grpc.BindableService)
    method io.grpc.internal.AbstractServerImplBuilder.addService(io.grpc.ServerServiceDefinition) is not applicable
      (argument mismatch; com.google.cloud.spanner.MockSpannerServiceImpl cannot be converted to io.grpc.ServerServiceDefinition)
    method io.grpc.internal.AbstractServerImplBuilder.addService(io.grpc.BindableService) is not applicable
      (argument mismatch; com.google.cloud.spanner.MockSpannerServiceImpl cannot be converted to io.grpc.BindableService)
[ERROR] /tmpfs/src/github/java-spanner-jdbc/src/test/java/com/google/cloud/spanner/jdbc/JdbcGrpcErrorTest.java:[110,13] no suitable method found for addService(com.google.cloud.spanner.MockSpannerServiceImpl)
    method io.grpc.ServerBuilder.addService(io.grpc.ServerServiceDefinition) is not applicable
      (argument mismatch; com.google.cloud.spanner.MockSpannerServiceImpl cannot be converted to io.grpc.ServerServiceDefinition)
    method io.grpc.ServerBuilder.addService(io.grpc.BindableService) is not applicable
      (argument mismatch; com.google.cloud.spanner.MockSpannerServiceImpl cannot be converted to io.grpc.BindableService)
    method io.grpc.internal.AbstractServerImplBuilder.addService(io.grpc.ServerServiceDefinition) is not applicable
      (argument mismatch; com.google.cloud.spanner.MockSpannerServiceImpl cannot be converted to io.grpc.ServerServiceDefinition)
    method io.grpc.internal.AbstractServerImplBuilder.addService(io.grpc.BindableService) is not applicable
      (argument mismatch; com.google.cloud.spanner.MockSpannerServiceImpl cannot be converted to io.grpc.BindableService)

@olavloite could these tests be fixed or is there something that we need to fix in the Spanner client?
@skuruppu skuruppu added priority: p2 Moderately-important priority. Fix may not be included in next release. type: question Request for information or clarification. Not an issue. api: spanner Issues related to the googleapis/java-spanner-jdbc API. labels Feb 13, 2020
@olavloite olavloite mentioned this issue Feb 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olavloite olavloite

Labels
api: spanner Issues related to the googleapis/java-spanner-jdbc API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: question Request for information or clarification. Not an issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: include Spanner gRPC test dependencies googleapis/java-spanner-jdbc
2 participants
@skuruppu @olavloite