Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for WITH clauses #42

Merged
merged 1 commit into from Jan 28, 2020
Merged

fix: add support for WITH clauses #42

merged 1 commit into from Jan 28, 2020

Conversation

olavloite
Copy link
Collaborator

Cloud Spanner now also support WITH clauses in a SELECT statement. These clauses were not recognized by the JDBC driver.

Fixes #41

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 24, 2020
@codecov
Copy link

codecov bot commented Jan 24, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@b368b84). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #42   +/-   ##
=========================================
  Coverage          ?   77.83%           
  Complexity        ?     1721           
=========================================
  Files             ?       60           
  Lines             ?     5866           
  Branches          ?      825           
=========================================
  Hits              ?     4566           
  Misses            ?      926           
  Partials          ?      374
Impacted Files Coverage Δ Complexity Δ
...com/google/cloud/spanner/jdbc/StatementParser.java 87.97% <100%> (ø) 46 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b368b84...e2848d1. Read the comment docs.

Copy link
Contributor

@hengfengli hengfengli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good to see this supported by spanner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WITH queries are (probably) not supported in the JDBC driver
3 participants