Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: upgrade to Java 8 and JDBC 4.2 #397

Merged
merged 5 commits into from Mar 22, 2021
Merged

feat!: upgrade to Java 8 and JDBC 4.2 #397

merged 5 commits into from Mar 22, 2021

Conversation

olavloite
Copy link
Collaborator

Upgrades the JDBC driver to Java 8 and implements new methods added in JDBC 4.2. JDBC version 4.2 is linked with Java 8.

Drops support for Java 7.

Fixes #396

@olavloite
feat!: upgrade to Java 8 and JDBC 4.2
996ddf0 
Upgrade to Java 8 and implement new methods added in Java 8 for JDBC.
Drops support for Java 7.

Closes #396
@olavloite olavloite added semver: major Hint for users that this is an API breaking change. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Mar 18, 2021
@olavloite olavloite requested review from a team as code owners March 18, 2021 10:59
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 18, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner-jdbc API. label Mar 18, 2021
@generated-files-bot
Copy link

generated-files-bot bot commented Mar 18, 2021 •
edited

Warning: This pull request is touching the following templated files:

  • .github/workflows/ci.yaml
  • .kokoro/nightly/java7.cfg
  • .kokoro/presubmit/java7.cfg

@codecov
Copy link

codecov bot commented Mar 18, 2021 •
edited

Codecov Report

Merging #397 (8536899) into master (bc43d12) will increase coverage by 0.55%.
The diff coverage is 75.38%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #397      +/-   ##
============================================
+ Coverage     72.15%   72.70%   +0.55%     
- Complexity     1139     1162      +23     
============================================
  Files            24       24              
  Lines          3548     3583      +35     
  Branches        541      533       -8     
============================================
+ Hits           2560     2605      +45     
+ Misses          769      757      -12     
- Partials        219      221       +2
Impacted Files Coverage Δ Complexity Δ
.../google/cloud/spanner/jdbc/JdbcParameterStore.java 50.60% <ø> (+0.12%) 128.00 <0.00> (ø)
...ogle/cloud/spanner/jdbc/JdbcPreparedStatement.java 77.77% <0.00%> (+6.34%) 9.00 <0.00> (+1.00)
...google/cloud/spanner/jdbc/AbstractJdbcWrapper.java 68.70% <25.00%> (-0.26%) 53.00 <0.00> (ø)
...ogle/cloud/spanner/jdbc/AbstractJdbcStatement.java 59.52% <55.55%> (+3.32%) 35.00 <2.00> (+3.00)
...a/com/google/cloud/spanner/jdbc/JdbcStatement.java 69.69% <75.00%> (+1.95%) 45.00 <8.00> (+7.00)
...ud/spanner/jdbc/AbstractJdbcPreparedStatement.java 90.41% <100.00%> (+0.41%) 52.00 <2.00> (+2.00)
...ogle/cloud/spanner/jdbc/AbstractJdbcResultSet.java 100.00% <100.00%> (ø) 121.00 <4.00> (+4.00)
...oogle/cloud/spanner/jdbc/JdbcDatabaseMetaData.java 95.69% <100.00%> (+0.01%) 185.00 <2.00> (+2.00)
...java/com/google/cloud/spanner/jdbc/JdbcDriver.java 65.71% <100.00%> (+2.85%) 17.00 <2.00> (+2.00)
...le/cloud/spanner/jdbc/JdbcSqlExceptionFactory.java 55.12% <100.00%> (+10.68%) 9.00 <1.00> (+2.00)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc43d12...8536899. Read the comment docs.

@olavloite olavloite mentioned this pull request Mar 19, 2021
Merged
@thiagotnunes thiagotnunes merged commit 7eedfbc into master Mar 22, 2021
@thiagotnunes thiagotnunes deleted the java8 branch March 22, 2021 00:33
@release-please release-please bot mentioned this pull request Mar 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagotnunes thiagotnunes thiagotnunes approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/java-spanner-jdbc API. cla: yes This human has signed the Contributor License Agreement. semver: major Hint for users that this is an API breaking change. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat!: Upgrade to Java 8
2 participants
@olavloite @thiagotnunes