Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow setting min/max sessions #335

Merged
merged 7 commits into from Feb 18, 2021
Merged

feat: allow setting min/max sessions #335

merged 7 commits into from Feb 18, 2021

Conversation

olavloite
Copy link
Collaborator

@olavloite olavloite commented Jan 26, 2021 •
edited

Allows applications to specify min and max sessions for the backing SessionPool in the JDBC connection URL.

Fixes #334

@olavloite olavloite added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 26, 2021
@olavloite olavloite requested a review from a team as a code owner January 26, 2021 16:01
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner-jdbc API. label Jan 26, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 26, 2021
@olavloite olavloite removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 17, 2021
@codecov
Copy link

codecov bot commented Feb 17, 2021 •
edited

Codecov Report

Merging #335 (e292ad1) into master (eff34a0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #335   +/-   ##
=========================================
  Coverage     71.98%   71.98%           
  Complexity     1131     1131           
=========================================
  Files            24       24           
  Lines          3520     3520           
  Branches        537      537           
=========================================
  Hits           2534     2534           
  Misses          767      767           
  Partials        219      219
Impacted Files Coverage Δ Complexity Δ
...java/com/google/cloud/spanner/jdbc/JdbcDriver.java 62.85% <ø> (ø) 15.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eff34a0...e292ad1. Read the comment docs.

@olavloite olavloite merged commit a5862a5 into master Feb 18, 2021
@olavloite olavloite deleted the session-pool-options branch February 18, 2021 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagotnunes thiagotnunes thiagotnunes approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/java-spanner-jdbc API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Allow setting min/max sessions in JDBC
2 participants
@olavloite @thiagotnunes