feat: support default ClientInfo properties #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: spanner
olavloite
commented
Jan 17, 2021
| StructField.of("DEFAULT_VALUE", Type.string()), | ||
| StructField.of("DESCRIPTION", Type.string())), | ||
| Collections.<Struct>emptyList())); | ||
| Arrays.asList( |
There was a problem hiding this comment.
These default ClientInfo properties are described here: https://docs.oracle.com/javase/8/docs/api/java/sql/Connection.html#setClientInfo-java.lang.String-java.lang.String-
The names are case insensitive.
Codecov Report
@@ Coverage Diff @@
## master #324 +/- ##
============================================
+ Coverage 70.93% 71.30% +0.36%
- Complexity 1105 1112 +7
============================================
Files 24 24
Lines 3423 3474 +51
Branches 526 531 +5
============================================
+ Hits 2428 2477 +49
Misses 780 780
- Partials 215 217 +2
Continue to review full report at Codecov.
|
thiagotnunes
approved these changes
Jan 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for default
ClientInfoproperties. These are not required by the JDBC standard, but many applications (including IntelliJ) will try to set these, and will log a warning if they are not set. This will prevent that warning from being logged.As a next step, these
ClientInfoproperty values should be set asSessionLabelvalues in Cloud Spanner. This makes it possible to track which sessions are being used by which (JDBC) application.