Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report generated columns in JDBC metadata #290

Closed
olavloite opened this issue Dec 8, 2020 · 0 comments · Fixed by #291
Closed

Report generated columns in JDBC metadata #290

olavloite opened this issue Dec 8, 2020 · 0 comments · Fixed by #291
Assignees
@olavloite
Labels
api: spanner Issues related to the googleapis/java-spanner-jdbc API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@olavloite
Copy link
Collaborator

Google Cloud Spanner now supports generated columns. These should be reported as such in the JDBC metadata.
@olavloite olavloite added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Dec 8, 2020
@olavloite olavloite self-assigned this Dec 8, 2020
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner-jdbc API. label Dec 8, 2020
olavloite added a commit that referenced this issue Dec 8, 2020
@olavloite
feat: report whether column is generated in JDBC metadata
4432bc0 
Cloud Spanner now supports generated columns. These were reported as normal columns
in the JDBC metadata. These are now reported correctly as generated columns.

Fixes #290
@olavloite olavloite mentioned this issue Dec 8, 2020
Merged
olavloite added a commit that referenced this issue Dec 10, 2020
@olavloite
feat: report whether column is generated in JDBC metadata (#291)
9aa9a1f 
Cloud Spanner now supports generated columns. These were reported as normal columns
in the JDBC metadata. These are now reported correctly as generated columns.

Fixes #290
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olavloite olavloite

Labels
api: spanner Issues related to the googleapis/java-spanner-jdbc API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: report whether column is generated in JDBC metadata googleapis/java-spanner-jdbc
1 participant
@olavloite